On obligation errors point at the unfulfilled binding when possible by estebank · Pull Request #64151 · rust-lang/rust

estebank · 2019-09-04T17:19:47Z

rust-highfive · 2019-09-04T17:19:51Z

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2019-09-04T17:20:33Z

CC @nikomatsakis @Centril, I'd like a couple of extra eyes to make sure I'm not pointing at the wrong binding accidentally.

varkor · 2019-09-10T18:50:04Z

@bors r+

bors · 2019-09-10T18:50:05Z

📌 Commit 3109b1f47891a11037e446a5809bf385f5326b12 has been approved by varkor

estebank · 2019-09-11T17:27:40Z

Inconsistent output across multiple targets strikes again. CC #53081, @oli-obk I can't find the issue you recently pinged me in that tracked this exact issue.

oli-obk · 2019-09-11T18:04:40Z

Sorry on mobile until Friday. I don't know where it was

estebank · 2019-09-16T17:57:29Z

I believe this might be the same as #46948

estebank · 2019-09-22T18:55:39Z

Progress: fixed the NLL tests.

@bors r=varkor

bors · 2019-09-22T18:55:40Z

📌 Commit ff75124 has been approved by varkor

bors · 2019-09-22T22:34:29Z

⌛ Testing commit ff75124 with merge c0b7e71...

On obligation errors point at the unfulfilled binding when possible CC #42855, #64130, #64135. Fix#61860.

bors · 2019-09-23T02:25:03Z

☀️ Test successful - checks-azure
Approved by: varkor
Pushing c0b7e71 to master...

@estebank

consistent handling of missing sysroot spans Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue. I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor

@estebank

consistent handling of missing sysroot spans Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue. I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor

rust-highfive assigned varkor Sep 4, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2019

estebank commented Sep 4, 2019
View reviewed changes

Comment threadsrc/test/ui/anonymous-higher-ranked-lifetime.stderr Outdated

This comment has been minimized.
Sign in to view

estebank force-pushed the binding-error branch 2 times, most recently from 6e5a280 to 07ea946Compare September 4, 2019 19:27

Centril reviewed Sep 5, 2019
View reviewed changes

Comment threadsrc/librustc/hir/mod.rs Outdated
Comment threadsrc/librustc/hir/mod.rs Outdated
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/libsyntax/parse/parser/path.rs Outdated

estebank force-pushed the binding-error branch from d30abc5 to 3109b1fCompare September 5, 2019 06:47

This comment has been minimized.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2019

estebank mentioned this pull request Sep 16, 2019
When possible point at argument causing item obligation failure #64498
Merged

estebank force-pushed the binding-error branch from 3109b1f to eac2b02Compare September 16, 2019 18:25

This comment has been minimized.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2019

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2019

estebank added 10 commits September 22, 2019 11:33

On obligation errors point at the unfulfilled binding when possible
b370c11

Point at correct span for parenthesized types
c9d05aa

review comments
b214085

ignore musl target in tests to avoid issues with output differences
f81734b

Fix rebase
4e0437e

Point at type param when it's cause of unfulfilled obligation
4be51c8

review comments
d201e27

hack to avoid incorrect suggestion
3ea0d10

ignore-x86 instead of ignore-musl
7cef8b3

fix nll tests
ff75124

estebank force-pushed the binding-error branch from 58ffcbd to ff75124Compare September 22, 2019 18:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2019

bors added a commit that referenced this pull request Sep 22, 2019
Auto merge of#64151- estebank:binding-error, r=varkor
c0b7e71
On obligation errors point at the unfulfilled binding when possible CC #42855, #64130, #64135. Fix#61860.

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 23, 2019

bors merged commit ff75124 into rust-lang:masterSep 23, 2019

estebank mentioned this pull request Oct 18, 2019
Point at local similarly named element and tweak references to variants #65421
Merged

jebrosen mentioned this pull request Oct 27, 2019
Update uuid, unicode-xid and base64 rwf2/Rocket#1164
Closed

RalfJung mentioned this pull request Nov 2, 2019
consistent handling of missing sysroot spans #66049
Merged

jebrosen mentioned this pull request Nov 6, 2019
Support normalization of $SRC_DIR Manishearth/compiletest-rs#198
Closed

jebrosen mentioned this pull request Nov 9, 2019
--remap-path-prefix does not apply to secondary files in diagnostics #66251
Closed

csmoe mentioned this pull request Nov 13, 2019
ICE when using reference variable from iterator (instead of copying it): thread 'rustc' panicked at 'already borrowed: BorrowMutError' #66353
Closed

Uh oh!

Uh oh!

Conversation

estebank commented Sep 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 4, 2019

Uh oh!

estebank commented Sep 4, 2019

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

varkor commented Sep 10, 2019

Uh oh!

bors commented Sep 10, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

estebank commented Sep 11, 2019

Uh oh!

oli-obk commented Sep 11, 2019

Uh oh!

estebank commented Sep 16, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

estebank commented Sep 22, 2019

Uh oh!

bors commented Sep 22, 2019

Uh oh!

bors commented Sep 22, 2019

Uh oh!

bors commented Sep 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

estebank commented Sep 4, 2019•
edited
Loading