Skip to content

Opaque type locations in error message for clarity. - #64157

Merged
bors merged 1 commit into
rust-lang:masterfrom
gilescope:opaque-type-location
Sep 5, 2019
Merged

Opaque type locations in error message for clarity.#64157
bors merged 1 commit into
rust-lang:masterfrom
gilescope:opaque-type-location

Conversation

@gilescope

Copy link
Copy Markdown
Contributor

Attempts to fix#63167

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2019
@cramertj

Copy link
Copy Markdown
Member

This looks like a nice improvement, thanks!

@bors r+

@bors

bors commented Sep 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit fe2c6b1 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…ramertj
Opaque type locations in error message for clarity.
Attempts to fixrust-lang#63167
@CentrilCentril mentioned this pull request Sep 5, 2019
Comment threadsrc/librustc/infer/error_reporting/mod.rs Outdated
@Centril

Copy link
Copy Markdown
Contributor

@bors r=cramertj,Centril

@bors

bors commented Sep 5, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9483db5 has been approved by cramertj,Centril

Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…ramertj,Centril
Opaque type locations in error message for clarity.
Attempts to fixrust-lang#63167
@CentrilCentril mentioned this pull request Sep 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…ramertj,Centril
Opaque type locations in error message for clarity.
Attempts to fixrust-lang#63167
@CentrilCentril mentioned this pull request Sep 5, 2019
bors added a commit that referenced this pull request Sep 5, 2019
Rollup of 11 pull requests
Successful merges:
- #62848 (Use unicode-xid crate instead of libcore)
- #63774 (Fix `window.hashchange is not a function`)
- #63930 (Account for doc comments coming from proc macros without spans)
- #64003 (place: Passing `align` = `layout.align.abi`, when also passing `layout`)
- #64030 (Fix unlock ordering in SGX synchronization primitives)
- #64041 (use TokenStream rather than &[TokenTree] for built-in macros)
- #64051 (Add x86_64-linux-kernel target)
- #64063 (Fix const_err with `-(-0.0)`)
- #64083 (Point at appropriate arm on type error on if/else/match with one non-! arm)
- #64100 (Fix const eval bug breaking run-pass tests in Miri)
- #64157 (Opaque type locations in error message for clarity.)
Failed merges:
r? @ghost
@bors
bors merged commit 9483db5 into rust-lang:masterSep 5, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing error message with type unification of impl Traits

5 participants

@gilescope@rust-highfive@cramertj@bors@Centril