Skip to content

[doc] Added more prereqs and note about default directory - #64241

Merged
bors merged 1 commit into
rust-lang:masterfrom
aditya4d:install-doc
Sep 7, 2019
Merged

[doc] Added more prereqs and note about default directory#64241
bors merged 1 commit into
rust-lang:masterfrom
aditya4d:install-doc

Conversation

@aditya4d

@aditya4daditya4d commented Sep 6, 2019

Copy link
Copy Markdown

No description provided.

@rust-highfive

rust-highfive commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2019
@aditya4daditya4d changed the title Added more prereqs and note about default directory[doc] Added more prereqs and note about default directorySep 6, 2019
@Centril

Centril commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

@Mark-Simulacrum

Mark-Simulacrum commented Sep 6, 2019

Copy link
Copy Markdown
Member

@bors r+ rollup=always

@bors

bors commented Sep 6, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 7dd5c66 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2019
@aditya4d

aditya4d commented Sep 6, 2019

Copy link
Copy Markdown
Author

How to merge it?

@Mark-Simulacrum

Mark-Simulacrum commented Sep 6, 2019

Copy link
Copy Markdown
Member

It'll be merged by bors soon, see https://buildbot2.rust-lang.org/homu/queue/rust for queue.

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019
@Centril
Rollup merge ofrust-lang#64241- adityaatluri:install-doc, r=Mark-Si…
69121f5
…mulacrum
[doc] Added more prereqs and note about default directory
@CentrilCentril mentioned this pull request Sep 7, 2019
Merged
bors added a commit that referenced this pull request Sep 7, 2019
@bors
Auto merge of#64246- Centril:rollup-zey4o09, r=Centril
ef54f57
Rollup of 10 pull requests
Successful merges:
- #63919 (Use hygiene for AST passes)
- #63927 (Filter linkcheck spurious failure)
- #64149 (rustc_codegen_llvm: give names to non-alloca variable values.)
- #64192 (Bail out when encountering likely missing turbofish in parser)
- #64231 (Move the HIR CFG to `rustc_ast_borrowck`)
- #64233 (Correct pluralisation of various diagnostic messages)
- #64236 (reduce visibility)
- #64240 (Include compiler-rt in the source tarball)
- #64241 ([doc] Added more prereqs and note about default directory)
- #64243 (Move injection of attributes from command line to `libsyntax_ext`)
Failed merges:
r? @ghost
@bors
bors merged commit 7dd5c66 into rust-lang:masterSep 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aditya4d@rust-highfive@Centril@Mark-Simulacrum@bors@nikomatsakis