Uh oh!
There was an error while loading. Please reload this page.
test/c-variadic: Fix patterns on powerpc64 - #64256
Conversation
rust-highfive
commented
Sep 7, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
smaeul
commented
Sep 7, 2019
In regard to the failing tidy checks: I'm not sure how to make the lines shorter than 100 characters, when the string being matched is longer than that. |
rust-highfive
commented
Sep 7, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
Sep 9, 2019
Seems reasonable to me to land, and the error should be fixable with |
On architectures such as powerpc64 that use extend_integer_width_to in their C ABI processing, integer parameters shorter than the native register width will be annotated with the ArgAttribute::SExt or ArgAttribute::ZExt attribute, and that attribute will be included in the generated LLVM IR. In this test, all relevant parameters are `i32`, which will get the `signext` annotation on the relevant 64-bit architectures. Match both the annotated and non-annotated case, but enforce that the annotation is applied consistently.
c923e6a to
2f6e73cComparealexcrichton
commented
Sep 10, 2019
@bors: r+ |
bors
commented
Sep 10, 2019
📌 Commit 2f6e73c has been approved by |
…xcrichton test/c-variadic: Fix patterns on powerpc64 On architectures such as powerpc64 that use extend_integer_width_to in their C ABI processing, integer parameters shorter than the native register width will be annotated with the ArgAttribute::SExt or ArgAttribute::ZExt attribute, and that attribute will be included in the generated LLVM IR. In this test, all relevant parameters are `i32`, which will get the `signext` annotation on the relevant 64-bit architectures. Match both the annotated and non-annotated case, but enforce that the annotation is applied consistently.
Rollup of 8 pull requests Successful merges: - #63786 (Make `abs`, `wrapping_abs`, `overflowing_abs` const functions) - #63989 (Add Yaah to clippy toolstain notification list) - #64256 (test/c-variadic: Fix patterns on powerpc64) - #64292 (lowering: extend temporary lifetimes around await) - #64311 (lldb: avoid mixing "Hit breakpoint" message with other output.) - #64330 (Clarify E0507 to note Fn/FnMut relationship to borrowing) - #64331 (Changed instant is earlier to instant is later) - #64344 (rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly.) Failed merges: r? @ghost
On architectures such as powerpc64 that use extend_integer_width_to in
their C ABI processing, integer parameters shorter than the native
register width will be annotated with the ArgAttribute::SExt or
ArgAttribute::ZExt attribute, and that attribute will be included in the
generated LLVM IR.
In this test, all relevant parameters are
i32, which will get thesignextannotation on the relevant 64-bit architectures. Match boththe annotated and non-annotated case, but enforce that the annotation is
applied consistently.