Uh oh!
There was an error while loading. Please reload this page.
Refactor librustc_errors::Handler API - #64272
Merged
Merged
Conversation
Mark-Simulacrum
commented
Sep 7, 2019
MemberAuthor
cc @aturon as part of parallel rustc efforts |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fbstj
reviewed
Sep 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
from
September 9, 2019 14:23
52b3d1f to
0b94900Compare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
from
September 9, 2019 22:06
0b94900 to
33aaa1fCompare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
from
September 10, 2019 00:01
33aaa1f to
66cc1e3CompareMark-Simulacrum
commented
Sep 10, 2019
MemberAuthor
CI is green here and this is good to go for review |
bors
commented
Sep 14, 2019
Collaborator
☔ The latest upstream changes (presumably #64456) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
from
September 14, 2019 22:17
66cc1e3 to
8f210f3CompareMark-Simulacrum
commented
Sep 14, 2019
MemberAuthor
Rebased. |
bors
commented
Sep 15, 2019
Collaborator
☔ The latest upstream changes (presumably #60584) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
from
September 15, 2019 13:01
8f210f3 to
434e67bCompareMark-Simulacrum
commented
Sep 15, 2019
MemberAuthor
Rebased, again. |
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
2 times, most recently
from
September 16, 2019 20:43
5802065 to
71f9addCompare
This comment has been minimized.
This comment has been minimized.
This avoids concurrency-related bugs when locks are acquired for too short a time and similar cases.
Mark-Simulacrumforce-pushed
the
parallel-handler
branch
from
September 17, 2019 13:31
71f9add to
4cc5aaaCompareestebank
commented
Sep 18, 2019
Contributor
Sorry for the radio silence, I'll review this tomorrow. |
estebank
commented
Sep 22, 2019
Contributor
Thanks for the clean commit history. It all makes sense, but making it stand alone merge to minimize the chance for conflicts. @bors r+ rollup=never |
bors
commented
Sep 22, 2019
Collaborator
📌 Commit 4cc5aaa has been approved by |
bors
commented
Sep 23, 2019
Collaborator
bors added a commit
that referenced
this pull request
Sep 23, 2019
Refactor librustc_errors::Handler API This should be reviewed by-commit. The last commit moves all fields into an inner struct behind a single lock; this is done to prevent possible deadlocks in a multi-threaded compiler, as well as inconsistent state observation.
bors
commented
Sep 23, 2019
Collaborator
☀️ Test successful - checks-azure |
phansch added a commit
to phansch/rust
that referenced
this pull request
Oct 15, 2019
rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This commit just renames the DB variable from `db` to `diag` where it wasn't renamed.
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
Refactor: Rename `db` locals to `diag` rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed. r? @Mark-Simulacrum
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
Refactor: Rename `db` locals to `diag` rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed. r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be reviewed by-commit.
The last commit moves all fields into an inner struct behind a single lock; this is done to prevent possible deadlocks in a multi-threaded compiler, as well as inconsistent state observation.