Uh oh!
There was an error while loading. Please reload this page.
Fix Stdio::piped example code and lint - #64294
Merged
Merged
Conversation
Summary: Invoking `rev` does not add a trailing newline when none is present in the input (at least on my Debian). Nearby examples use `echo` rather than `rev`, which probably explains the source of the discrepancy. Also, a `mut` qualifier is unused. Test Plan: Copy the code block into <https://play.rust-lang.org> with a `fn main` wrapper, and run it. Note that it compiles and runs cleanly; prior to this commit, it would emit an `unused_mut` warning and then panic. wchargin-branch: stdio-piped-docs
rust-highfive
commented
Sep 8, 2019
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
JohnCSimon
commented
Sep 14, 2019
Ping from triage Thanks. |
JohnCSimon
commented
Sep 21, 2019
Pinging from triage |
Dylan-DPC-zz
commented
Sep 21, 2019
@bors: r+ |
bors
commented
Sep 21, 2019
Collaborator
📌 Commit 9bf5773 has been approved by |
Centril
commented
Sep 21, 2019
Contributor
r? @Dylan-DPC |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 22, 2019
… r=Dylan-DPC Fix `Stdio::piped` example code and lint Summary: Invoking `rev` does not add a trailing newline when none is present in the input (at least on my Debian). Nearby examples use `echo` rather than `rev`, which probably explains the source of the discrepancy. Also, a `mut` qualifier is unused. Test Plan: Copy the code block into <https://play.rust-lang.org> with a `fn main` wrapper, and run it. Note that it compiles and runs cleanly; prior to this commit, it would emit an `unused_mut` warning and then panic. wchargin-branch: stdio-piped-docs
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 22, 2019
… r=Dylan-DPC Fix `Stdio::piped` example code and lint Summary: Invoking `rev` does not add a trailing newline when none is present in the input (at least on my Debian). Nearby examples use `echo` rather than `rev`, which probably explains the source of the discrepancy. Also, a `mut` qualifier is unused. Test Plan: Copy the code block into <https://play.rust-lang.org> with a `fn main` wrapper, and run it. Note that it compiles and runs cleanly; prior to this commit, it would emit an `unused_mut` warning and then panic. wchargin-branch: stdio-piped-docs
bors added a commit
that referenced
this pull request
Sep 23, 2019
Rollup of 7 pull requests Successful merges: - #64294 (Fix `Stdio::piped` example code and lint) - #64670 (Cleanup syntax::ext::build) - #64674 (Propagate `types.err` in locals further to avoid spurious knock-down errors) - #64676 (Parse assoc type bounds in generic params and provide custom diagnostic) - #64677 (remove outdated comment) - #64679 (Infer consts more consistently) - #64688 (Clarify the "since" tidy check) Failed merges: r? @ghost
wchargin
commented
Sep 23, 2019
ContributorAuthor
Thanks for the review! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Invoking
revdoes not add a trailing newline when none is present inthe input (at least on my Debian). Nearby examples use
echoratherthan
rev, which probably explains the source of the discrepancy.Also, a
mutqualifier is unused.Test Plan:
Copy the code block into https://play.rust-lang.org with a
fn mainwrapper, and run it. Note that it compiles and runs cleanly; prior to
this commit, it would emit an
unused_mutwarning and then panic.wchargin-branch: stdio-piped-docs