Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #64313
Merged
Merged
Conversation
Arm, Field, FieldPat, GenericParam, Param, StructField and Variant
Resolve attributes in several places Resolve attributes for Arm, Field, FieldPat, GenericParam, Param, StructField and Variant. This PR is based on @petrochenkov work located at petrochenkov@83fdb8d.
… r=scottmcm
Override `StepBy::{try_fold, try_rfold}`
Previous PR: rust-lang#51435
The previous PR was closed in favor of rust-lang#51601, which was later reverted. I don't think these implementations will make it harder to specialize `StepBy<Range<_>>` later, so we should be able to land this without any consequences.
This should fixrust-lang#57517 – in my benchmarks `iter` and `iter.step_by(1)` now perform equally well, provided internal iteration is used.check git in bootstrap.py
Fix typo in config.toml.example
…andling, r=Mark-Simulacrum Unify escape usage Fixesrust-lang#63443. I chose to keep the search text when pressing escape so when we focus on the search bar, we got the results again without needing to load them again. I also unified a bit a few things (maybe I should have done it in another commit, sorry...). r? @Mark-Simulacrum
Centril
commented
Sep 9, 2019
ContributorAuthor
@bors r+ p=5 rollup=never |
bors
commented
Sep 9, 2019
Collaborator
📌 Commit f7ee130 has been approved by |
bors
commented
Sep 9, 2019
Collaborator
bors
commented
Sep 9, 2019
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
StepBy::{try_fold, try_rfold}#64121 (OverrideStepBy::{try_fold, try_rfold})Failed merges:
r? @ghost