Uh oh!
There was an error while loading. Please reload this page.
Don't create subprocesses for the rust command - #6438
Merged
Conversation
Instead link against the built libraries and directly invoke those.
alexcrichton
commented
May 13, 2013
MemberAuthor
@thestinger, could you retry bors? I've seen that error a few times before and I think it's an intermittent one that isn't related to this... |
bors added a commit
that referenced
this pull request
May 13, 2013
Instead link against the built libraries and directly invoke those. Closes#5387
bors added a commit
that referenced
this pull request
May 13, 2013
I changed the dependencies of librust in #6438, but I forgot to update the dependencies in the Makefile, this should have the dependencies right now.
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
6438: Deny unreachable-pub r=matklad a=matklad It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs rust-lang/cargo#5034. Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead link against the built libraries and directly invoke those.
Closes#5387