Skip to content

Fix false "never constructed" warnings for Self:: variant paths - #64424

Closed
jakubadamw wants to merge 1 commit into
rust-lang:masterfrom
jakubadamw:issue-64362
Closed

Fix false "never constructed" warnings for Self:: variant paths#64424
jakubadamw wants to merge 1 commit into
rust-lang:masterfrom
jakubadamw:issue-64362

Conversation

@jakubadamw

@jakubadamwjakubadamw commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Closes#64362.

@rust-highfive

rust-highfive commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2019
@estebank

estebank commented Sep 14, 2019

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 10ed1f1 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge ofrust-lang#64424- jakubadamw:issue-64362, r=estebank
4d32778
Fix false "never constructed" warnings for `Self::` variant paths
Closesrust-lang#64362.
@CentrilCentril mentioned this pull request Sep 14, 2019
Closed
@Centril

Centril commented Sep 14, 2019

Copy link
Copy Markdown
Contributor

Assigning blame of failure in #64449 (comment) to this PR, @bors r-

(This is a guestimate)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 14, 2019
@jakubadamw

jakubadamw commented Sep 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril, no, the failure is unrelated.

@Centril

Centril commented Sep 14, 2019

Copy link
Copy Markdown
Contributor

@jakubadamw Any alternate theory? This PR seemed to be the only one related to TypeckTables somehow...

@jakubadamw

jakubadamw commented Sep 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril, sorry, you're absolutely right. Looking into this.

@JohnCSimon

JohnCSimon commented Sep 20, 2019

Copy link
Copy Markdown

Ping from triage.
@jakubadamw Hello! Can you please post your status regarding this PR?
Thank you.

@bors

bors commented Sep 27, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #64813) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimonJohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Oct 5, 2019
@JohnCSimon

JohnCSimon commented Oct 5, 2019

Copy link
Copy Markdown

Ping from triage.
@jakubadamw This PR has sat idle for the last few weeks, I'm going to close this due to inactivity.
If you have time to move this forward please re-open this PR.
CC @estebank

Thank you!

@seiyabseiyab mentioned this pull request Feb 22, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

S-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"variant is never constructed" lint appears to be incorrect?

6 participants

@jakubadamw@rust-highfive@estebank@bors@Centril@JohnCSimon