Uh oh!
There was an error while loading. Please reload this page.
Warn on no_start, crate_id attribute use - #64471
Conversation
rust-highfive
commented
Sep 14, 2019
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Sep 14, 2019
I'm not marking as relnotes as these attributes have done nothing since pre-1.0 so there's no compatibility note that I think we should issue. |
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Sep 14, 2019
Could we try cratering the removal? Maybe no one actually uses it and we can remove some tech debt. |
Mark-Simulacrum
commented
Sep 14, 2019
The tech debt is so minimal that it doesn't seem worth it, but if you'd like me to I can delete the attributes and we can run crater on that PR. Up to you. |
Centril
commented
Sep 14, 2019
@Mark-Simulacrum I just checked and I agree that the tech debt is very minimal (basically 4 boilerplate lines in total). Let's deprecate for now. |
These attributes are now deprecated; they don't have any use anymore.
80d0fa6 to
a0e48b6CompareMark-Simulacrum
commented
Sep 14, 2019
Alright, updated, extracting the function to avoid duplicating the suggestion. |
Centril
commented
Sep 14, 2019
@rust-lang/lang N.B. this deprecates two attributes that have had no effect in ages per the description in the PR... This could ostensibly be FCPed but I'm dispensing with this because it I expect the PR will be wildly uncontroversial. Nonethless, here's a heads-up. @bors r+ rollup |
bors
commented
Sep 14, 2019
📌 Commit a0e48b6 has been approved by |
…entril Warn on no_start, crate_id attribute use These attributes are now deprecated; they don't have any use anymore. `no_start` stopped being applicable in 3ee916e as part of rust-lang#18967. Ideally we would've removed it pre-1.0, but since that didn't happen let's at least mark it deprecated. `crate_id` was renamed to `crate_name` in 50ee1ec as part of rust-lang#15319. Ideally we would've followed that up with a removal of crate_id itself as well, but that didn't happen; this PR finally marks it as deprecated at least. Fixesrust-lang#43142 and resolvesrust-lang#43144.
Rollup of 5 pull requests Successful merges: - #64457 (def_collector: Do not ICE on attributes on unnamed fields) - #64463 (resolve: Tweak some expected/found wording) - #64471 (Warn on no_start, crate_id attribute use) - #64473 (Use try_fold instead of manually carrying an accumulator) - #64475 (simplify the initialization) Failed merges: r? @ghost
remove long-deprecated no-op attributes no_start and crate_id These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything.
…yukang remove long-deprecated no-op attributes no_start and crate_id These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything. In fact they [apparently](rust-lang#64471 (comment)) have done nothing since pre-1.0, so... do we even need a crater run? Doesn't seem worth it.
Rollup merge of rust-lang#134300 - RalfJung:remove-dead-attrs, r=chenyukang remove long-deprecated no-op attributes no_start and crate_id These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything. In fact they [apparently](rust-lang#64471 (comment)) have done nothing since pre-1.0, so... do we even need a crater run? Doesn't seem worth it.
These attributes are now deprecated; they don't have any use anymore.
no_startstopped being applicable in 3ee916e as part of #18967. Ideally we would've removed it pre-1.0, but since that didn't happen let's at least mark it deprecated.crate_idwas renamed tocrate_namein 50ee1ec as part of #15319. Ideally we would've followed that up with a removal of crate_id itself as well, but that didn't happen; this PR finally marks it as deprecated at least.Fixes#43142 and resolves#43144.