Skip to content

Print out more information for -Zunpretty=expanded,hygiene - #64486

Merged
bors merged 2 commits into
rust-lang:masterfrom
matthewjasper:hygiene-debugging
Sep 18, 2019
Merged

Print out more information for -Zunpretty=expanded,hygiene#64486
bors merged 2 commits into
rust-lang:masterfrom
matthewjasper:hygiene-debugging

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Sep 15, 2019

Copy link
Copy Markdown
Contributor

I've found this helpful when trying to understand how hygiene works.

Closes#16420

@rust-highfive

rust-highfive commented Sep 15, 2019

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2019
@Mark-Simulacrum

Mark-Simulacrum commented Sep 15, 2019

Copy link
Copy Markdown
Member

r? @petrochenkov probably

@petrochenkov

petrochenkov commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Thanks!
I previously just did the format!("{:#?}", data) thing manually when necessary.

petrochenkov
petrochenkov reviewed Sep 16, 2019
View reviewed changes
Comment threadsrc/libsyntax_pos/hygiene.rs Outdated
Comment threadsrc/test/ui/hygiene/unpretty-debug.stdout Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2019
@matthewjaspermatthewjasper added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2019
@petrochenkov

petrochenkov commented Sep 17, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 3c2fd1a has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2019
@bors

bors commented Sep 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3c2fd1a with merge ae996db1ece7955a3914345964c6ed8184a83f77...

tmandry added a commit to tmandry/rust that referenced this pull request Sep 18, 2019
@tmandry
Rollup merge ofrust-lang#64486- matthewjasper:hygiene-debugging, r=…
48e2308
…petrochenkov
Print out more information for `-Zunpretty=expanded,hygiene`
I've found this helpful when trying to understand how hygiene works.
Closesrust-lang#16420
@tmandrytmandry mentioned this pull request Sep 18, 2019
Closed
@tmandry

tmandry commented Sep 18, 2019

Copy link
Copy Markdown
Member

@bors retry rolled up

@bors

bors commented Sep 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3c2fd1a with merge 81e91693356868bcfd3f96e0ab4b71d44e567ae8...

tmandry added a commit to tmandry/rust that referenced this pull request Sep 18, 2019
@tmandry
Rollup merge ofrust-lang#64486- matthewjasper:hygiene-debugging, r=…
c7b5567
…petrochenkov
Print out more information for `-Zunpretty=expanded,hygiene`
I've found this helpful when trying to understand how hygiene works.
Closesrust-lang#16420
@tmandrytmandry mentioned this pull request Sep 18, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 18, 2019
@tmandry
Rollup merge ofrust-lang#64486- matthewjasper:hygiene-debugging, r=…
a8aa511
…petrochenkov
Print out more information for `-Zunpretty=expanded,hygiene`
I've found this helpful when trying to understand how hygiene works.
Closesrust-lang#16420
@tmandrytmandry mentioned this pull request Sep 18, 2019
Merged
@tmandry

tmandry commented Sep 18, 2019

Copy link
Copy Markdown
Member

@bors retry rolled up

bors added a commit that referenced this pull request Sep 18, 2019
@bors
Auto merge of#64570- tmandry:rollup-3pg02lj, r=tmandry
64c0969
Rollup of 4 pull requests
Successful merges:
- #64486 (Print out more information for `-Zunpretty=expanded,hygiene`)
- #64503 (rename Allocation::retag -> with_tags_and_extra)
- #64516 (update Nomicon and Reference)
- #64528 (Load proc macro metadata in the correct order.)
Failed merges:
r? @ghost
@bors
bors merged commit 3c2fd1a into rust-lang:masterSep 18, 2019
@matthewjasper
matthewjasper deleted the hygiene-debugging branch September 19, 2019 18:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Syntax context output in --pretty expanded,hygiene doesn't represent linked syntax contexts

7 participants

@matthewjasper@rust-highfive@Mark-Simulacrum@petrochenkov@bors@tmandry@nikomatsakis