Skip to content

use println!() instead of println!("") - #64504

Merged
bors merged 1 commit into
rust-lang:masterfrom
guanqun:use-println-without-empty-str
Sep 16, 2019
Merged

use println!() instead of println!("")#64504
bors merged 1 commit into
rust-lang:masterfrom
guanqun:use-println-without-empty-str

Conversation

@guanqun

Copy link
Copy Markdown

The empty string is unnecessary.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2019
@jonas-schievink

Copy link
Copy Markdown
Contributor

Thanks!

r? @jonas-schievink@bors r+ rollup

@bors

bors commented Sep 16, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 5355a16 has been approved by jonas-schievink

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 16, 2019
…tr, r=jonas-schievink
use println!() instead of println!("")
The empty string is unnecessary.
@CentrilCentril mentioned this pull request Sep 16, 2019
bors added a commit that referenced this pull request Sep 16, 2019
Rollup of 10 pull requests
Successful merges:
- #63955 (Make sure interned constants are immutable)
- #64028 (Stabilize `Vec::new` and `String::new` as `const fn`s)
- #64119 (ci: ensure all tool maintainers are assignable on issues)
- #64444 (fix building libstd without backtrace feature)
- #64446 (Fix build script sanitizer check.)
- #64451 (when Miri tests are not passing, do not add Miri component)
- #64467 (Hide diagnostics emitted during --cfg parsing)
- #64497 (Don't print the "total" `-Ztime-passes` output if `--prints=...` is also given)
- #64499 (Use `Symbol` in two more functions.)
- #64504 (use println!() instead of println!(""))
Failed merges:
r? @ghost
@bors
bors merged commit 5355a16 into rust-lang:masterSep 16, 2019
@guanqun
guanqun deleted the use-println-without-empty-str branch September 16, 2019 23:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guanqun@rust-highfive@jonas-schievink@bors@nikomatsakis