Skip to content

Rollup of 4 pull requests - #64526

Merged
bors merged 10 commits into
rust-lang:masterfrom
Centril:rollup-k4cz2xn
Sep 17, 2019
Merged

Rollup of 4 pull requests#64526
bors merged 10 commits into
rust-lang:masterfrom
Centril:rollup-k4cz2xn

Conversation

@Centril

Copy link
Copy Markdown
Contributor

Successful merges:

Failed merges:

r? @ghost

varkorand others added 10 commits September 16, 2019 15:43
Fixes some extra blank lines and makes some minor tweaks to the wording.
`AdtDef` is an algebraic data type, not abstract data type
r? @varkor
update Miri
Fixesrust-lang#64363
r? @alexcrichton for the Cargo.toml changes: with byteorder 1.3, the `i128` feature is a NOP, so we can remove it everywhere and then get rid of this crate in the workspace-hack.
…r=Centril
Make some adjustments to the documentation for `std::convert::identity`
Fixes some extra blank lines and makes some minor tweaks to the wording.
…r-proj-slice, r=oli-obk
Use while let slice_pattern instead of carrying an index around
r? @oli-obk
@Centril

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=4 rollup=never

@bors

bors commented Sep 16, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1376ccd has been approved by Centril

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 16, 2019
@bors

bors commented Sep 16, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1376ccd with merge 7ac21e7...

bors added a commit that referenced this pull request Sep 16, 2019
Rollup of 4 pull requests
Successful merges:
- #64357 (`AdtDef` is an algebraic data type, not abstract data type)
- #64485 (update Miri)
- #64509 (Make some adjustments to the documentation for `std::convert::identity`)
- #64518 (Use while let slice_pattern instead of carrying an index around)
Failed merges:
r? @ghost
@bors

bors commented Sep 17, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 7ac21e7 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 17, 2019
@bors
bors merged commit 1376ccd into rust-lang:masterSep 17, 2019
@rust-highfive

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #64526!

Tested on commit 7ac21e7.
Direct link to PR: #64526

🎉 miri on windows: build-fail → test-pass (cc @oli-obk@eddyb@RalfJung, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk@eddyb@RalfJung, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 17, 2019
Tested on commit rust-lang/rust@7ac21e7.
Direct link to PR: <rust-lang/rust#64526>
🎉 miri on windows: build-fail → test-pass (cc @oli-obk@eddyb@RalfJung, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk@eddyb@RalfJung, @rust-lang/infra).
@Centril
Centril deleted the rollup-k4cz2xn branch September 17, 2019 01:10
@CentrilCentril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Centril@bors@rust-highfive@varkor@RalfJung@spastorino