Uh oh!
There was an error while loading. Please reload this page.
Fix a minor grammar nit, update UI tests - #64591
Merged
Merged
Conversation
rust-highfive
commented
Sep 18, 2019
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
varkor
commented
Sep 18, 2019
Contributor
bors
commented
Sep 18, 2019
Collaborator
📌 Commit f233a4c has been approved by |
| LL | impl Foo<i32> for i32 { } | ||
| | --------------------- first implementation here | ||
| LL | | ||
| LL | |
Contributor
There was a problem hiding this comment.
Just checked locally, this whitespace is significant
jonas-schievink
commented
Sep 18, 2019
Contributor
@bors r- |
jamesmunns
commented
Sep 18, 2019
ContributorAuthor
I think this whitespace is a mistake itself (calling |
jonas-schievink
commented
Sep 18, 2019
Contributor
@bors r+ |
bors
commented
Sep 18, 2019
Collaborator
📌 Commit 333230f has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 18, 2019
…ievink Fix a minor grammar nit, update UI tests Minor fix, but I noticed it while debugging some code
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 19, 2019
…ievink Fix a minor grammar nit, update UI tests Minor fix, but I noticed it while debugging some code
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 19, 2019
…ievink Fix a minor grammar nit, update UI tests Minor fix, but I noticed it while debugging some code
bors added a commit
that referenced
this pull request
Sep 19, 2019
Rollup of 5 pull requests Successful merges: - #63630 (Update installed compiler dependencies) - #64536 (Update Cargo) - #64554 (Polonius: more `ui` test suite fixes) - #64566 (A more generic interface for dataflow analysis) - #64591 (Fix a minor grammar nit, update UI tests) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix, but I noticed it while debugging some code