Skip to content

rustbuild: Improve output of dist step - #64618

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:improve-dist-output
Sep 22, 2019
Merged

rustbuild: Improve output of dist step#64618
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:improve-dist-output

Conversation

@alexcrichton

Copy link
Copy Markdown
Member
  • Pass /Q to iscc on Windows to supress the thousands of lines of
    output about compressing documentation.
  • Print out what's happening before long steps
  • Use timeit to print out timing information for long-running
    installer assemblies.
  • Try to scope output of Dist ... to not also encompass actual build steps

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
@alexcrichton

Copy link
Copy Markdown
MemberAuthor

r? @Mark-Simulacrum

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2019
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

  • Pass /Q to iscc on Windows to supress the thousands of lines of
    output about compressing documentation.

This won't silence errors, right? I guess even if it does, we probably haven't seen an error here in ages so doesn't matter too much.

@bors

bors commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 255dd3f has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 20, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@CentrilCentril mentioned this pull request Sep 20, 2019
bors added a commit that referenced this pull request Sep 20, 2019
Rollup of 8 pull requests
Successful merges:
- #64136 (Document From trait for LhsExpr in parser)
- #64342 (factor out pluralisation remains after #64280)
- #64387 (Fix redundant semicolon lint interaction with proc macro attributes)
- #64498 (When possible point at argument causing item obligation failure)
- #64615 (rustbuild: Turn down compression on exe installers)
- #64617 (rustbuild: Turn down compression on msi installers)
- #64618 (rustbuild: Improve output of `dist` step)
- #64621 (Add Compatibility Notes to RELEASES.md for 1.38.0)
Failed merges:
r? @ghost
@alexcrichton

Copy link
Copy Markdown
MemberAuthor

According to this at least/Q should still print errors

Centril added a commit to Centril/rust that referenced this pull request Sep 20, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@CentrilCentril mentioned this pull request Sep 20, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandrytmandry mentioned this pull request Sep 20, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandrytmandry mentioned this pull request Sep 20, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandrytmandry mentioned this pull request Sep 20, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandrytmandry mentioned this pull request Sep 20, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 21, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandrytmandry mentioned this pull request Sep 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
…=Mark-Simulacrum
rustbuild: Improve output of `dist` step
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@CentrilCentril mentioned this pull request Sep 21, 2019
bors added a commit that referenced this pull request Sep 22, 2019
Rollup of 9 pull requests
Successful merges:
- #63907 (Add explanation to type mismatch involving type params and assoc types)
- #64615 (rustbuild: Turn down compression on exe installers)
- #64617 (rustbuild: Turn down compression on msi installers)
- #64618 (rustbuild: Improve output of `dist` step)
- #64619 (Fixes#63962. Hint about missing tuple parentheses in patterns)
- #64634 (Update to LLVM 9.0.0)
- #64635 (Allow using fn pointers in const fn with unleash miri)
- #64660 (unify errors for tuple/struct variants)
- #64664 (fully remove AstBuilder)
Failed merges:
r? @ghost
@bors
bors merged commit 255dd3f into rust-lang:masterSep 22, 2019
@alexcrichton
alexcrichton deleted the improve-dist-output branch September 23, 2019 19:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcrichton@rust-highfive@Mark-Simulacrum@bors@nikomatsakis