Skip to content

Exempt extern "Rust" from improper_ctypes - #64641

Merged
bors merged 1 commit into
rust-lang:masterfrom
cuviper:extern-rust-ctypes
Sep 21, 2019
Merged

Exempt extern "Rust" from improper_ctypes#64641
bors merged 1 commit into
rust-lang:masterfrom
cuviper:extern-rust-ctypes

Conversation

@cuviper

Copy link
Copy Markdown
Member

It should be fine for Rust ABIs to involve any Rust type.

Fixes#64593.

It should be fine for Rust ABIs to involve any Rust type.
@cuviper

Copy link
Copy Markdown
MemberAuthor

Hmm, no bot? How about...
r? @estebank

@cuvipercuviper added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2019
@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9f374da has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 21, 2019
Exempt extern "Rust" from improper_ctypes
It should be fine for Rust ABIs to involve any Rust type.
Fixesrust-lang#64593.
@tmandrytmandry mentioned this pull request Sep 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
Exempt extern "Rust" from improper_ctypes
It should be fine for Rust ABIs to involve any Rust type.
Fixesrust-lang#64593.
@CentrilCentril mentioned this pull request Sep 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
Exempt extern "Rust" from improper_ctypes
It should be fine for Rust ABIs to involve any Rust type.
Fixesrust-lang#64593.
@CentrilCentril mentioned this pull request Sep 21, 2019
bors added a commit that referenced this pull request Sep 21, 2019
Rollup of 9 pull requests
Successful merges:
- #64010 (Stabilize `param_attrs` in Rust 1.39.0)
- #64136 (Document From trait for LhsExpr in parser)
- #64342 (factor out pluralisation remains after #64280)
- #64347 (Add long error explanation for E0312)
- #64621 (Add Compatibility Notes to RELEASES.md for 1.38.0)
- #64632 (remove the extra comma after the match arm)
- #64640 (No home directory on vxWorks)
- #64641 (Exempt extern "Rust" from improper_ctypes)
- #64642 (Fix the span used to suggest avoiding for-loop moves)
Failed merges:
r? @ghost
@bors
bors merged commit 9f374da into rust-lang:masterSep 21, 2019
@cuviper
cuviper deleted the extern-rust-ctypes branch April 3, 2020 18:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary improper_ctypes warning for extern "Rust"

3 participants

@cuviper@estebank@bors