Skip to content

[beta] rollup of last set of backports - #64661

Merged
bors merged 4 commits into
rust-lang:betafrom
Mark-Simulacrum:beta-next
Sep 22, 2019
Merged

[beta] rollup of last set of backports#64661
bors merged 4 commits into
rust-lang:betafrom
Mark-Simulacrum:beta-next

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Sep 21, 2019•
edited
Loading

Copy link
Copy Markdown
Member

XAMPPRockyand others added 4 commits September 21, 2019 12:26
@XAMPPRocky@Mark-Simulacrum
Updated RELEASES.md for 1.38.0
d8052d8
@pnkfelix@Mark-Simulacrum
Make fn ptr always structural match, regardless of whether formal typ…
f3ebfab
…es are.
Fixrust-lang#63479.
@pnkfelix@Mark-Simulacrum
Regression tests for fn ptr and#[structural_match]as discussed inr…
73c70ca
…ust-lang#63479.
@emilyalbini@Mark-Simulacrum
ci: split aws credentials in two separate users with scoped perms
e8d2957
This commit changes our CI to use two separate IAM users to
authenticate with AWS:
* ci--rust-lang--rust--sccache: has access to the rust-lang-ci-sccache2
S3 bucket and its credentials are available during the whole build.
* ci--rust-lang--rust--upload: has access to the rust-lang-ci2 S3 bucket
and its credentials are available just during the upload step.
The new tokens are available in the `prod-credentials` library.
@CentrilCentril closed this Sep 21, 2019
@CentrilCentril reopened this Sep 21, 2019
@Mark-Simulacrum

Mark-Simulacrum commented Sep 21, 2019

Copy link
Copy Markdown
MemberAuthor

@bors try

@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit e8d2957 with merge cab0dd4d50cabfc3b268acb5b7f5247be485dc9a...

@Mark-Simulacrum

Mark-Simulacrum commented Sep 21, 2019

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=50

@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit e8d2957 has been approved by Mark-Simulacrum

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 21, 2019
@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e8d2957 with merge 39dabb998bc2a9da811ccf144955c16f90aefd2d...

@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2019
@Centril

Centril commented Sep 21, 2019

Copy link
Copy Markdown
Contributor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019
@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e8d2957 with merge 1c65325...

bors added a commit that referenced this pull request Sep 21, 2019
@bors
Auto merge of#64661- Mark-Simulacrum:beta-next, r=Mark-Simulacrum
1c65325
[beta] rollup of last set of backports
* ci: split aws credentials in two separate users with scoped perms #64576
* Updated RELEASES.md for 1.38.0 #64283
* Add Compatibility Notes to RELEASES.md for 1.38.0 #64621
@bors

bors commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 1c65325 to beta...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2019
@bors
bors merged commit e8d2957 into rust-lang:betaSep 22, 2019
@CentrilCentril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mark-Simulacrum@bors@Centril@XAMPPRocky@pnkfelix@emilyalbini