Skip to content

Use span label instead of note in unreachable lint - #64669

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:unreachable
Sep 22, 2019
Merged

Use span label instead of note in unreachable lint#64669
bors merged 2 commits into
rust-lang:masterfrom
estebank:unreachable

Conversation

@estebank

@estebankestebank commented Sep 21, 2019

Copy link
Copy Markdown
Contributor

Fix#64636.

@rust-highfive

rust-highfive commented Sep 21, 2019

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2019
Centril
Centril reviewed Sep 21, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with suggestions applied.

Comment threadsrc/test/ui/lint/unreachable-async-fn.rs Outdated
Comment threadsrc/test/ui/lint/unreachable-async-fn.rs
Comment threadsrc/test/ui/lint/unreachable-async-fn.rs
@Centril

Centril commented Sep 21, 2019

Copy link
Copy Markdown
Contributor

r? @Centril

@rust-highfiverust-highfive assigned Centril and unassigned varkorSep 21, 2019
@Centril

Centril commented Sep 21, 2019

Copy link
Copy Markdown
Contributor

@bors p=2

@estebank

estebank commented Sep 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Sep 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9991d54 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019
@bors

bors commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9991d54 with merge 4ff32c0...

bors added a commit that referenced this pull request Sep 22, 2019
@bors
Auto merge of#64669- estebank:unreachable, r=Centril
4ff32c0
Use span label instead of note in unreachable lint
Fix#64636.
@bors

bors commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 4ff32c0 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2019
@bors
bors merged commit 9991d54 into rust-lang:masterSep 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

async functions with unimplemented!() are marked as unreachable

5 participants

@estebank@rust-highfive@Centril@bors@varkor