Uh oh!
There was an error while loading. Please reload this page.
fix several issues in String docs - #64737
Merged
Merged
Conversation
- In some places &str was shown instead of String. - into_bytes is the reverse of from_utf8 Fixesrust-lang#63797
rust-highfive
commented
Sep 24, 2019
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
steveklabnik
approved these changes
Sep 24, 2019
steveklabnik
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, thank you!
steveklabnik
commented
Sep 24, 2019
Contributor
@bors: r+ rollup |
bors
commented
Sep 24, 2019
Collaborator
📌 Commit 62dc794 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 24, 2019
fix several issues in String docs - In some places &str was shown instead of String. - into_bytes is the reverse of from_utf8 Fixesrust-lang#63797 I've retaken the work done in this PR: rust-lang#63865 which for some reason was closed. and just done a minor change (I hope you don't mind @sam09 ).
bors added a commit
that referenced
this pull request
Sep 24, 2019
Rollup of 16 pull requests Successful merges: - #63356 (Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example) - #63934 (Fix coherence checking for impl trait in type aliases) - #64016 (Streamline `Compiler`) - #64296 (Document the unstable iter_order_by library feature) - #64443 (rustdoc: general cleanup) - #64622 (Add a cycle detector for generic `Graph`s and `mir::Body`s) - #64689 (Refactor macro by example) - #64698 (Recover on `const X = 42;` and infer type + Error Stash API) - #64702 (Remove unused dependencies) - #64717 (update mem::discriminant test to use assert_eq and assert_ne over comparison operators) - #64720 ( remove rtp.rs, and move rtpSpawn and RTP_ID_ERROR to libc) - #64721 (Fixed issue from #64447) - #64725 (fix one typo) - #64737 (fix several issues in String docs) - #64742 (relnotes: make compatibility section more sterile and fix rustc version) - #64748 (Fix#64744. Account for the Zero sub-pattern case.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#63797
I've retaken the work done in this PR: #63865 which for some reason was closed.
and just done a minor change (I hope you don't mind @sam09 ).