Uh oh!
There was an error while loading. Please reload this page.
std: Reduce checks for feature = "backtrace" - #64765
Merged
Merged
Conversation
This is a stylistic change to libstd to reduce the number of checks of `feature = "backtrace"` now that we unconditionally depend on the `backtrace` crate and rely on it having an empty implementation. otherwise.
rust-highfive
commented
Sep 25, 2019
Contributor
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Sep 25, 2019
MemberAuthor
r? @sfackler |
sfackler
commented
Sep 25, 2019
Member
Do we need to do anything to ensure that |
alexcrichton
commented
Sep 25, 2019
MemberAuthor
Nah this is all in one CGU typically anyway or should be inlined with ThinLTO |
JohnCSimon
commented
Oct 5, 2019
Ping from triage Thanks |
sfackler
commented
Oct 5, 2019
Member
@bors r+ |
bors
commented
Oct 5, 2019
Collaborator
📌 Commit 1d06058 has been approved by |
bors
commented
Oct 5, 2019
Collaborator
⌛ Testing commit 1d06058 with merge dbb2bda43aa5730a8df2a4deb30766462d4066c9... |
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Oct 5, 2019
…r=sfackler std: Reduce checks for `feature = "backtrace"` This is a stylistic change to libstd to reduce the number of checks of `feature = "backtrace"` now that we unconditionally depend on the `backtrace` crate and rely on it having an empty implementation. otherwise.
tmandry
commented
Oct 5, 2019
Member
@bors retry rolled up |
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Oct 6, 2019
…r=sfackler std: Reduce checks for `feature = "backtrace"` This is a stylistic change to libstd to reduce the number of checks of `feature = "backtrace"` now that we unconditionally depend on the `backtrace` crate and rely on it having an empty implementation. otherwise.
bors added a commit
that referenced
this pull request
Oct 6, 2019
Rollup of 18 pull requests This contains changes from all the successful runs that bors marked as timed out, plus a revert of #63649 which appears to be the immediate cause of the timeouts. Successful merges: - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`) - #64728 (Stabilize UdpSocket::peer_addr) - #64765 (std: Reduce checks for `feature = "backtrace"`) - #64909 (When encountering chained operators use heuristics to recover from bad turbofish) - #65011 (Do not ICE when dereferencing non-Copy raw pointer) - #65064 (permit asyncawait-ondeck to be added by anyone) - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR) - #65100 (Replace GeneratorSubsts with SubstsRef) - #65105 (Split out some passes from librustc) - #65106 (Allow unused attributes to avoid incremental bug) - #65113 (Fix lonely backtick) - #65116 (Remove unneeded visit_statement definition) - #65118 (Update the documented default of -Z mutable-noalias) - #65123 (Account for macro invocation in `let mut $pat` diagnostic.) - #65124 (Replace some instances of `as *[const | mut] _` with `.cast()`) - #65126 (Fix typo on `now()` comments) - #65130 (lint: extern non-exhaustive types are improper) - #65151 (Revert #63649 - "Upgrade Emscripten targets to use upstream LLVM backend") Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stylistic change to libstd to reduce the number of checks of
feature = "backtrace"now that we unconditionally depend on thebacktracecrate and rely on it having an empty implementation.otherwise.