Uh oh!
There was an error while loading. Please reload this page.
Remove stray references to the old global tcx - #64781
Merged
Merged
Conversation
rust-highfive
commented
Sep 25, 2019
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Sep 25, 2019
MemberAuthor
r? @Centril perhaps? |
Centril
commented
Sep 25, 2019
Contributor
Don't have enough context sorry :) r? @nikomatsakis |
eddyb
approved these changes
Sep 26, 2019
eddyb
commented
Sep 26, 2019
Contributor
@bors r+ |
bors
commented
Sep 26, 2019
Collaborator
📌 Commit 4469bdd has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 26, 2019
Remove stray references to the old global tcx
bors
commented
Sep 26, 2019
Collaborator
☔ The latest upstream changes (presumably #64513) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrumforce-pushed
the
no-global-tcx
branch
from
September 27, 2019 01:14
4469bdd to
a1e21beCompareMark-Simulacrum
commented
Sep 27, 2019
MemberAuthor
@bors r=eddyb |
bors
commented
Sep 27, 2019
Collaborator
📌 Commit a1e21be has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 27, 2019
Remove stray references to the old global tcx
bors
commented
Sep 27, 2019
Collaborator
☔ The latest upstream changes (presumably #64813) made this pull request unmergeable. Please resolve the merge conflicts. |
The non-global context was removed; there's only one context now. This is a noop method that only serves to confuse readers -- remove it.
There's no longer two distinct gcx and tcx lifetimes which made this necessary (or, at least, the code compiles -- it's possible we got better at normalizing, but that seems unlikely).
Mark-Simulacrumforce-pushed
the
no-global-tcx
branch
from
September 27, 2019 17:34
a1e21be to
4b23503CompareMark-Simulacrum
commented
Sep 27, 2019
MemberAuthor
@bors r=eddyb |
bors
commented
Sep 27, 2019
Collaborator
📌 Commit 4b23503 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 28, 2019
Remove stray references to the old global tcx
bors added a commit
that referenced
this pull request
Sep 28, 2019
Rollup of 14 pull requests Successful merges: - #63492 (Remove redundancy from the implementation of C variadics.) - #64703 (Docs: slice elements are equidistant) - #64745 (Include message on tests that should panic but do not) - #64781 (Remove stray references to the old global tcx) - #64794 (Remove unused DepTrackingMap) - #64802 (Account for tail expressions when pointing at return type) - #64809 (hir: Disallow `target_feature` on constants) - #64815 (Fix div_duration() marked as stable by mistake) - #64818 (update rtpSpawn's parameters type(It's prototype has been updated in libc)) - #64830 (Thou shallt not `.abort_if_errors()`) - #64836 (Stabilize map_get_key_value feature) - #64845 (pin.rs: fix links to primitives in documentation) - #64847 (Upgrade env_logger to 0.7) - #64851 (Add mailmap entry for Dustin Bensing by request) Failed merges: - #64824 (No StableHasherResult everywhere) r? @ghost
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 28, 2019
Remove stray references to the old global tcx
bors added a commit
that referenced
this pull request
Sep 28, 2019
Rollup of 14 pull requests Successful merges: - #64703 (Docs: slice elements are equidistant) - #64745 (Include message on tests that should panic but do not) - #64781 (Remove stray references to the old global tcx) - #64794 (Remove unused DepTrackingMap) - #64802 (Account for tail expressions when pointing at return type) - #64809 (hir: Disallow `target_feature` on constants) - #64815 (Fix div_duration() marked as stable by mistake) - #64818 (update rtpSpawn's parameters type(It's prototype has been updated in libc)) - #64830 (Thou shallt not `.abort_if_errors()`) - #64836 (Stabilize map_get_key_value feature) - #64845 (pin.rs: fix links to primitives in documentation) - #64847 (Upgrade env_logger to 0.7) - #64851 (Add mailmap entry for Dustin Bensing by request) - #64859 (check_match: improve diagnostics for `let A = 2;` with `const A: i32 = 3`) Failed merges: r? @ghost
matthiaskrgr added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Sep 28, 2019
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Sep 28, 2019
rustup rust-lang/rust#64781 cc rust-lang/rust#64867 changelog: none
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Sep 28, 2019
rustup rust-lang/rust#64781 cc rust-lang/rust#64867 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.