[const-prop] Handle remaining MIR Rvalue cases by wesleywiser · Pull Request #64890 · rust-lang/rust

wesleywiser · 2019-09-29T06:39:32Z

r? @oli-obk

oli-obk · 2019-09-30T12:33:19Z

just a formatting nit, then this lgtm.

oli-obk · 2019-09-30T13:01:33Z

@bors r+

bors · 2019-09-30T13:01:34Z

📌 Commit 5804c3b has been approved by oli-obk

@oli-obk

…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

@oli-obk

…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

@oli-obk

…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

Centril · 2019-10-01T14:09:19Z

(Speculation) Failed in #64955 (comment), @bors r-

bjorn3 · 2019-10-01T14:15:21Z

Assertion location:

rust/src/librustc_mir/interpret/place.rs

Line 1032 in 702b45e

assert_eq!(index, variant_index);

joelpalmer · 2019-10-07T11:30:53Z

Ping from Triage: any updates @wesleywiser?

wesleywiser · 2019-10-08T00:57:36Z

Got married this weekend; I'll probably get back to this later this week :)

wesleywiser · 2019-10-09T10:10:18Z

@oli-obk Pushed a fix. Let me know what you think.

wesleywiser · 2019-10-18T15:51:17Z

A mir-opt test I added failed because wasm doesn't support unwinding. I'll fix this tonight.

Per code review feedback

wesleywiser · 2019-10-18T23:18:02Z

Added ignore-{wasm,enscripten} to the box test.

@bors r=oli-obk

bors · 2019-10-18T23:18:03Z

📌 Commit fd20dbe has been approved by oli-obk

bors · 2019-10-19T04:54:24Z

⌛ Testing commit fd20dbe with merge bf46d1b81e0f1be41abd66dabb21515f6d0bfdc7...

Centril · 2019-10-19T04:59:30Z

@bors rollup=never retry yielding to r0llup

bors · 2019-10-19T05:06:54Z

⌛ Testing commit fd20dbe with merge 662301e2a9170f3aba36b6f4df7fec1309606866...

Centril · 2019-10-19T05:11:08Z

@bors retry yielding to r0llup

bors · 2019-10-19T08:59:46Z

⌛ Testing commit fd20dbe with merge e5b8c11...

@oli-obk

[const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

bors · 2019-10-19T12:42:30Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing e5b8c11 to master...

@wesleywiser

…eywiser clarify const_prop ICE protection comment This is based on discussion at https://github.com/rust-lang/rust/pull/64890/files#r334555787. That said, why are function arguments the only unsized locals that could remain uninitialized? Couldn't we also fail to initialize some local but still go on with const_prop, and then hit a line that takes a reference to that? Cc @wesleywiser @oli-obk ; I don't know enough about const-prop to understand why this can happen only for function arguments. ~~The PR includes rust-lang#64890; the only new commit is 05e4e6ba0d5.~~

@oli-obk

…<try> [mir-opt] Implement pass to remove branches on uninhabited variants Based on discussion [here](#64890 (comment)), this is a pass to eliminate dead code that is caused by branching on an enum with uninhabited variants. r? @oli-obk

@oli-obk

…oli-obk [mir-opt] Implement pass to remove branches on uninhabited variants Based on discussion [here](#64890 (comment)), this is a pass to eliminate dead code that is caused by branching on an enum with uninhabited variants. r? @oli-obk

rust-highfive assigned oli-obk Sep 29, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2019

oli-obk reviewed Sep 29, 2019
View reviewed changes

Comment threadsrc/test/mir-opt/while-storage.rs Outdated

oli-obk reviewed Sep 29, 2019
View reviewed changes

Comment threadsrc/test/mir-opt/const_prop/boxes.rs Outdated

wesleywiser force-pushed the const_prop_rvalue branch 2 times, most recently from d8549cb to 4982daeCompare September 30, 2019 12:24

oli-obk reviewed Sep 30, 2019
View reviewed changes

Comment threadsrc/librustc_mir/transform/const_prop.rs Outdated

wesleywiser force-pushed the const_prop_rvalue branch 2 times, most recently from c3cdb89 to 5804c3bCompare September 30, 2019 12:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2019

Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
Rollup merge ofrust-lang#64890- wesleywiser:const_prop_rvalue, r=ol…
8436080
…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

Centril mentioned this pull request Oct 1, 2019
Rollup of 4 pull requests #64951
Closed

Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
Rollup merge ofrust-lang#64890- wesleywiser:const_prop_rvalue, r=ol…
aab99cf
…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

Centril mentioned this pull request Oct 1, 2019
Rollup of 4 pull requests #64954
Closed

Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
Rollup merge ofrust-lang#64890- wesleywiser:const_prop_rvalue, r=ol…
4707702
…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

Centril mentioned this pull request Oct 1, 2019
Rollup of 5 pull requests #64955
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2019

wesleywiser added 4 commits October 18, 2019 19:16

[const-prop] Handle MIR Rvalue::Box
2d22063

Cleanup const_prop() some
8cf6c23

Don't ICE when evaluating writes to uninhabited enum variants
b71ea80

Improve comments and structure of ConstProp::const_prop()
fd20dbe
Per code review feedback

wesleywiser force-pushed the const_prop_rvalue branch from 883148b to fd20dbeCompare October 18, 2019 23:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2019

bors added a commit that referenced this pull request Oct 19, 2019
Auto merge of#64890- wesleywiser:const_prop_rvalue, r=oli-obk
e5b8c11
[const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

RalfJung mentioned this pull request Oct 19, 2019
clarify const_prop ICE protection comment #65592
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2019

bors merged commit fd20dbe into rust-lang:masterOct 19, 2019

wesleywiser mentioned this pull request Oct 22, 2019
[mir-opt] Implement pass to remove branches on uninhabited variants #65694
Merged

bytwise mentioned this pull request Dec 2, 2019
Miscompilation of tuple arguments with mir-opt-level=2 #66971
Closed

Uh oh!

Uh oh!

Conversation

wesleywiser commented Sep 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Sep 30, 2019

Uh oh!

oli-obk commented Sep 30, 2019

Uh oh!

bors commented Sep 30, 2019

Uh oh!

Centril commented Oct 1, 2019

Uh oh!

bjorn3 commented Oct 1, 2019

Uh oh!

joelpalmer commented Oct 7, 2019

Uh oh!

wesleywiser commented Oct 8, 2019

Uh oh!

wesleywiser commented Oct 9, 2019

Uh oh!

wesleywiser commented Oct 18, 2019

Uh oh!

wesleywiser commented Oct 18, 2019

Uh oh!

bors commented Oct 18, 2019

Uh oh!

bors commented Oct 19, 2019

Uh oh!

Centril commented Oct 19, 2019

Uh oh!

bors commented Oct 19, 2019

Uh oh!

Centril commented Oct 19, 2019

Uh oh!

bors commented Oct 19, 2019

Uh oh!

bors commented Oct 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants