Skip to content

Document JSON message output. - #64925

Merged
bors merged 1 commit into
rust-lang:masterfrom
ehuss:document-json
Oct 18, 2019
Merged

Document JSON message output.#64925
bors merged 1 commit into
rust-lang:masterfrom
ehuss:document-json

Conversation

@ehuss

@ehussehuss commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

This documents the JSON messages in the rustc book.

@rust-highfive

rust-highfive commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@JohnCSimon

JohnCSimon commented Oct 12, 2019

Copy link
Copy Markdown

Ping from triage
@QuietMisdreavus Can you please review this?

@Mark-Simulacrum

Mark-Simulacrum commented Oct 17, 2019

Copy link
Copy Markdown
Member

@bors r+

I believe that this documentation is not adding to our stability guarantees as it is explicit about what we guarantee (new fields, new variants can be added). In any case, I consider rustc book to be somewhat non-normative, though maybe this is not true in practice. I think the JSON interface of rustc we are somewhat less likely to care about breaking (since it affects build tools, rather than source code, and less build tools exist).

@bors

bors commented Oct 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f04ea6c has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 18, 2019
@Centril
Rollup merge ofrust-lang#64925- ehuss:document-json, r=Mark-Simulacrum
2997a58
Document JSON message output.
This documents the JSON messages in the rustc book.
@CentrilCentril mentioned this pull request Oct 18, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge ofrust-lang#64925- ehuss:document-json, r=Mark-Simulacrum
cb41fb6
Document JSON message output.
This documents the JSON messages in the rustc book.
@tmandrytmandry mentioned this pull request Oct 18, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge ofrust-lang#64925- ehuss:document-json, r=Mark-Simulacrum
2d536c0
Document JSON message output.
This documents the JSON messages in the rustc book.
@tmandrytmandry mentioned this pull request Oct 18, 2019
Closed
@bors

bors commented Oct 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f04ea6c with merge 518deda...

bors added a commit that referenced this pull request Oct 18, 2019
@bors
Auto merge of#64925- ehuss:document-json, r=Mark-Simulacrum
518deda
Document JSON message output.
This documents the JSON messages in the rustc book.
@borsbors mentioned this pull request Oct 18, 2019
Merged
@bors

bors commented Oct 18, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 518deda to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 18, 2019
@bors
bors merged commit f04ea6c into rust-lang:masterOct 18, 2019
@borsbors mentioned this pull request Oct 18, 2019
Merged
@rust-highfive

rust-highfive commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #64925!

Tested on commit 518deda.
Direct link to PR: #64925

💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 18, 2019
@rust-highfive
📣 Toolstate changed byrust-lang/rust#64925!
82489c5
Tested on commit rust-lang/rust@518deda.
Direct link to PR: <rust-lang/rust#64925>
💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ehuss@rust-highfive@JohnCSimon@Mark-Simulacrum@bors@QuietMisdreavus