Rollup of 8 pull requests by tmandry · Pull Request #64966 · rust-lang/rust

tmandry · 2019-10-01T18:52:48Z

Successful merges:

apfloat: improve doc comments #63416 (apfloat: improve doc comments)
Make all alt builders produce parallel-enabled compilers #64722 (Make all alt builders produce parallel-enabled compilers)
BTreeSet intersection, is_subset & difference optimizations #64820 (BTreeSet intersection, is_subset & difference optimizations)
SelfProfiler API refactoring and part one of event review #64840 (SelfProfiler API refactoring and part one of event review)
syntax: cleanup param, method, and misc parsing #64910 (syntax: cleanup param, method, and misc parsing)
Remove unneeded fn main blocks from docs #64912 (Remove unneeded fn main blocks from docs)
Fixes #64919. Suggest fix based on operator precendence. #64933 (FixesSuggested fix does not account for operator precedence #64919. Suggest fix based on operator precendence.)
Update cargo. #64952 (Update cargo.)

Failed merges:

We're not quite ready to ship parallel compilers by default, but the alt builders are not used too much (in theory), so we believe that shipping a possibly-broken compiler there is not too problematic.

…ible.

… new API.

This changes the default parallelism for parallel compilers to one, instead of the previous default, which was "num cpus". This is likely not an optimal default long-term, but it is a good default for testing whether parallel compilers are not a significant regression over a sequential compiler. Notably, this in theory makes a parallel-enabled compiler behave exactly like a sequential compiler with respect to the jobserver.

@eddyb

apfloat: improve doc comments r? @eddyb @nagisa

@nikomatsakis

…xcrichton Make all alt builders produce parallel-enabled compilers We're not quite ready to ship parallel compilers by default, but the alt builders are not used too much (in theory), so we believe that shipping a possibly-broken compiler there is not too problematic. r? @nikomatsakis

BTreeSet intersection, is_subset & difference optimizations ...based on the range of values contained; in particular, a massive improvement when these ranges are disjoint (or merely touching), like in the neg-vs-pos benchmarks already in liballoc. Inspired by rust-lang#64383 but none of the ideas there worked out. I introduced another variant in IntersectionInner and in DifferenceInner, because I couldn't find a way to initialize these iterators as empty if there's no empty set around. Also, reduced the size of "large" sets in test cases - if Miri can't handle it, it was needlessly slowing down everyone.

@wesleywiser

…i-refactor, r=wesleywiser SelfProfiler API refactoring and part one of event review This PR refactors the `SelfProfiler` a little bit so that most profiling methods are RAII-based. The codegen backend code already had something similar, this refactoring pulls this functionality up into `SelfProfiler` itself, for general use. The second commit of this PR is a review and update of the existing events we are already recording. Names have been made more consistent. CGU names have been removed from event names. They will be added back in when function parameter recording is implemented. There is still some work to be done for adding new events, especially around trait resolution and the incremental system. r? @wesleywiser

@petrochenkov

syntax: cleanup param, method, and misc parsing Do some misc cleanup of the parser: - Method and parameter parsing is refactored. - A parser for `const | mut` is introduced that rust-lang#64588 can reuse. - Some other misc parsing. Next up in a different PR: - ~Implementing rust-lang#64252 -- maybe some other time... - Heavily restructuring up `item.rs` which is a mess (hopefully, no promises ^^). r? @petrochenkov

…chievink Remove unneeded `fn main` blocks from docs ## [No whitespace diff](https://github.com/rust-lang/rust/pull/64912/files?w=1)

Fixesrust-lang#64919. Suggest fix based on operator precendence. Fixesrust-lang#64919

@alexcrichton

…excrichton Update cargo. Pulls rust-lang/cargo@f3c92ed into nightly Rust. r? @alexcrichton

tmandry · 2019-10-01T18:53:01Z

@bors r+ p=8 rollup=never

bors · 2019-10-01T18:53:02Z

📌 Commit f38b393 has been approved by tmandry

bors · 2019-10-01T18:54:25Z

⌛ Testing commit f38b393 with merge 52f5edf48dd086f207437cd01a96c4bfd893b580...

bors · 2019-10-01T21:36:54Z

💔 Test failed - checks-azure

Centril · 2019-10-01T21:45:42Z

Either the Alt PR or Cargo was the cause of the failure I think.

tmandry · 2019-10-01T21:52:14Z

Either the Alt PR or Cargo was the cause of the failure I think.

From the logs, I think it was Cargo.

RalfJungand others added 30 commits August 9, 2019 19:33

apfloat: improve doc comments
5faae38

Make all alt builders produce parallel-enabled compilers
a3639c6
We're not quite ready to ship parallel compilers by default, but the alt builders are not used too much (in theory), so we believe that shipping a possibly-broken compiler there is not too problematic.

syntax: cleanup method parsing.
f290467

syntax: is_named_argument -> is_named_param.
378cc98

syntax refactor parse_fn_params
4fa9c3b

syntax refactor parse_self_param (1)
40dc9da

syntax refactor parse_self_param (2)
f688f8a

syntax refactor parse_self_param (3)
ac454e9

syntax refactor parse_self_param (4)
4306d00

syntax refactor parse_self_param (5)
0492302

syntax: reorder param parsing to make more sense.
347deac

syntax: cleanup parse_fn_decl.
d9d0e5d

syntax: misc cleanup
5b80ead

syntax: cleanup parse_visibility.
66bf323

syntax: extract error_on_invalid_abi.
573a8d8

syntax: fuse more code paths together.
258e86a

syntax: stylistic cleanup in item parsing.
bea404f

syntax: reduce repetition in fn parsing.
151ce96

Self-Profiling: Refactor SelfProfiler API to be RAII based where poss…
b0b073c
…ible.

Self-Profiling: Make names of existing events more consistent and use…
d942622
… new API.

Fixesrust-lang#64919. Suggest fix based on operator precendence.
c9baaa7

syntax: document some methods.
df298b4

syntax: put helpers of parse_self_param in the method.
30647d1

syntax: merge things back into parse_visibility.
49780d2

syntax: de-closure-ify check_or_expected.
e046904

syntax: reformat passing of FnHeader to parse_item_fn.
5c5dd80

Change to use exprPrecedence instead of exprKind.
9e4eb46

Update cargo.
e1d9f82

Remove unneeded fn main blocks from docs
6c1b447

alexcrichtonand others added 10 commits October 1, 2019 06:11

Update Cargo.lock for cargo update
3173a09

BTreeSet intersection, difference & is_subnet optimizations
d132a70

Rollup merge ofrust-lang#63416- RalfJung:apfloat, r=eddyb
431c075
apfloat: improve doc comments r? @eddyb @nagisa

Rollup merge ofrust-lang#64912- lzutao:unneeded-main-doc, r=jonas-s…
4492cd3
…chievink Remove unneeded `fn main` blocks from docs ## [No whitespace diff](https://github.com/rust-lang/rust/pull/64912/files?w=1)

Rollup merge ofrust-lang#64933- sam09:master, r=estebank
9c43861
Fixesrust-lang#64919. Suggest fix based on operator precendence. Fixesrust-lang#64919

Rollup merge ofrust-lang#64952- michaelwoerister:update-cargo, r=al…
f38b393
…excrichton Update cargo. Pulls rust-lang/cargo@f3c92ed into nightly Rust. r? @alexcrichton

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 1, 2019

tmandry mentioned this pull request Oct 1, 2019
Rollup of 7 pull requests #64965
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2019

Centril closed this Oct 1, 2019

tmandry mentioned this pull request Oct 1, 2019
Update cargo. #64952
Merged

tmandry deleted the rollup-yw4z9xs branch October 1, 2019 22:06

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Navigation Menu

Uh oh!

Uh oh!

Rollup of 8 pull requests - #64966

Rollup of 8 pull requests#64966
tmandry wants to merge 40 commits into
rust-lang:masterfrom
tmandry:rollup-yw4z9xs

tmandry commented Oct 1, 2019

Uh oh!

tmandry commented Oct 1, 2019

Uh oh!

bors commented Oct 1, 2019

Uh oh!

bors commented Oct 1, 2019

Uh oh!

bors commented Oct 1, 2019

Uh oh!

Centril commented Oct 1, 2019

Uh oh!

tmandry commented Oct 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

tmandry commented Oct 1, 2019

Uh oh!

tmandry commented Oct 1, 2019

Uh oh!

bors commented Oct 1, 2019

Uh oh!

bors commented Oct 1, 2019

Uh oh!

bors commented Oct 1, 2019

Uh oh!

Centril commented Oct 1, 2019

Uh oh!

tmandry commented Oct 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants