Compute the layout of uninhabited structs by oli-obk · Pull Request #64987 · rust-lang/rust

oli-obk · 2019-10-02T09:01:26Z

eddyb · 2019-10-03T11:16:55Z

 assert!(field < count as u64,
- "Tried to access field {} of union with {} fields", field, count);
+ "Tried to access field {} of union {:#?} with {} fields",
+ field, base.layout, count);


Can you add this assert to FieldPlacement::offset? And even add an offset_u64, if you want (I guess offset(i) can just call offset_u64(i as u64)? or maybe we just want an i: impl Into<u64> on offset).

u64 does not implement From<usize> :(

eddyb · 2019-10-14T12:57:26Z

@bors r+

bors · 2019-10-14T12:57:28Z

📌 Commit 373c362 has been approved by eddyb

bors · 2019-10-14T13:51:36Z

⌛ Testing commit 373c362 with merge 2fe9b4b0bf4f8842e26f58d928cf6a5d5153fbfa...

@eddyb

…=eddyb Compute the layout of uninhabited structs fixesrust-lang#64506 r? @eddyb

Centril · 2019-10-14T13:55:22Z

@bors retry rolled up.

bors · 2019-10-14T15:35:45Z

⌛ Testing commit 373c362 with merge 434fcab8166c6478551efb023d412fa6e67b0731...

rust-highfive · 2019-10-14T15:40:43Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-10-14T15:40:59Z

💔 Test failed - checks-azure

Centril · 2019-10-14T15:52:21Z

@bors retry

bors · 2019-10-14T15:52:57Z

⌛ Testing commit 373c362 with merge e413dc3...

@eddyb

Compute the layout of uninhabited structs fixes#64506 r? @eddyb

alex · 2019-10-14T15:55:35Z

@Centril I assume you noticed, but just in case, FYI every single build appears to be failing on a connection error to the azure ubuntu apt repos.

emilyalbini · 2019-10-14T16:00:15Z

@bors treeclosed=1000

Centril · 2019-10-14T16:00:16Z

@bors treeclose=1000 network problems

emilyalbini · 2019-10-14T16:15:49Z

@bors treeclosed-

This build seems to be ok.

bors · 2019-10-14T19:45:42Z

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing e413dc3 to master...

Compute the layout of uninhabited structs
4eb5fcb

rust-highfive assigned eddyb Oct 2, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2019

oli-obk mentioned this pull request Oct 2, 2019
ICE when const evaluating UB #64506
Closed

Centril reviewed Oct 2, 2019
View reviewed changes

Comment threadsrc/test/ui/issues/issue-64506.rs
Comment threadsrc/librustc/ty/layout.rs Outdated

eddyb reviewed Oct 3, 2019
View reviewed changes

RalfJung reviewed Oct 9, 2019
View reviewed changes

Comment threadsrc/librustc_mir/interpret/place.rs

oli-obk added 3 commits October 9, 2019 19:09

Move test next to likeminded ones
76a7667

Refactor a nested if to a match
76fe6a4

Check that we don't access nonexisting union fields
373c362

eddyb approved these changes Oct 14, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2019

Centril added a commit to Centril/rust that referenced this pull request Oct 14, 2019
Rollup merge ofrust-lang#64987- oli-obk:code_reuse_prevents_bugs, r…
9611993
…=eddyb Compute the layout of uninhabited structs fixesrust-lang#64506 r? @eddyb

Centril mentioned this pull request Oct 14, 2019
Rollup of 4 pull requests #65406
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2019

bors added a commit that referenced this pull request Oct 14, 2019
Auto merge of#64987- oli-obk:code_reuse_prevents_bugs, r=eddyb
e413dc3
Compute the layout of uninhabited structs fixes#64506 r? @eddyb

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 14, 2019

bors merged commit 373c362 into rust-lang:masterOct 14, 2019

bors mentioned this pull request Oct 14, 2019
Create compilation target versions of ::alloc::Layout#64299
Closed

Mark-Simulacrum mentioned this pull request Feb 15, 2020
beta regression: ICE on Tried to access field 0 of union Layout #69191
Closed

oli-obk deleted the code_reuse_prevents_bugs branch March 6, 2020 10:03

eddyb mentioned this pull request Mar 6, 2020
Compute the correct layout for variants of uninhabited enums #69768
Merged

Uh oh!

Uh oh!

Conversation

oli-obk commented Oct 2, 2019

Uh oh!

Uh oh!

Uh oh!

eddybOct 3, 2019

Choose a reason for hiding this comment

Uh oh!

oli-obkOct 9, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eddyb commented Oct 14, 2019

Uh oh!

bors commented Oct 14, 2019

Uh oh!

bors commented Oct 14, 2019

Uh oh!

Centril commented Oct 14, 2019

Uh oh!

bors commented Oct 14, 2019

Uh oh!

rust-highfive commented Oct 14, 2019

Uh oh!

bors commented Oct 14, 2019

Uh oh!

Centril commented Oct 14, 2019

Uh oh!

bors commented Oct 14, 2019

Uh oh!

alex commented Oct 14, 2019

Uh oh!

emilyalbini commented Oct 14, 2019

Uh oh!

Centril commented Oct 14, 2019

Uh oh!

emilyalbini commented Oct 14, 2019

Uh oh!

bors commented Oct 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants