Skip to content

Document missing deny by default lints - #65039

Merged
bors merged 1 commit into
rust-lang:masterfrom
197g:deny-by-default-book
Oct 13, 2019
Merged

Document missing deny by default lints#65039
bors merged 1 commit into
rust-lang:masterfrom
197g:deny-by-default-book

Conversation

@197g

@197g197g commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2019
Comment threadsrc/doc/rustc/src/lints/listing/deny-by-default.md Outdated
@197g
197gforce-pushed the deny-by-default-book branch from 0689f83 to 334bafeCompareOctober 3, 2019 02:46
@jhpratt

Copy link
Copy Markdown
Member

Ideally, all of the documentation for lints should be updated. There are a number that are out of date or outright missing (like rust_2018_idioms, which encompasses a few others). At least for me, it's somewhat of a guessing game to figure out which one belongs where.

@JohnCSimon

Copy link
Copy Markdown

Ping from triage
@GuillaumeGomez can you please review this pr?
cc: @HeroicKatora

thanks.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Oct 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 334bafe has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 13, 2019
…r=GuillaumeGomez
Document missing deny by default lints
@CentrilCentril mentioned this pull request Oct 13, 2019
bors added a commit that referenced this pull request Oct 13, 2019
Rollup of 13 pull requests
Successful merges:
- #65039 (Document missing deny by default lints)
- #65069 (Implement Clone::clone_from for VecDeque)
- #65165 (Improve docs on some char boolean methods)
- #65248 (Suggest `if let` on `let` refutable binding)
- #65250 (resolve: fix error title regarding private constructors)
- #65295 (Move diagnostics code out of the critical path)
- #65320 (Report `CONST_ERR` lint in external macros)
- #65327 (replace the hand-written binary search with the library one)
- #65339 (do not reference LLVM for our concurrency memory model)
- #65357 (syntax: simplify maybe_annotate_with_ascription)
- #65358 (simplify maybe_stage_features)
- #65359 (simplify integer_lit)
- #65360 (mbe: reduce panictry! uses.)
Failed merges:
r? @ghost
@bors
bors merged commit 334bafe into rust-lang:masterOct 13, 2019
@197g
197g deleted the deny-by-default-book branch October 13, 2019 15:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@197g@rust-highfive@jhpratt@JohnCSimon@GuillaumeGomez@bors@Centril