Skip to content

Custom lifetime error for impl item doesn't conform to trait - #65068

Merged
bors merged 6 commits into
rust-lang:masterfrom
estebank:trait-impl-lt-mismatch
Oct 30, 2019
Merged

Custom lifetime error for impl item doesn't conform to trait#65068
bors merged 6 commits into
rust-lang:masterfrom
estebank:trait-impl-lt-mismatch

Conversation

@estebank

@estebankestebank commented Oct 3, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Partly addresses #42706, #41343, fix#40900.

@rust-highfive

rust-highfive commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Oct 3, 2019
View reviewed changes
Comment threadsrc/librustc/infer/error_reporting/nice_region_error/trait_impl_difference.rs Outdated
Centril
Centril reviewed Oct 3, 2019
View reviewed changes
Comment threadsrc/librustc/infer/error_reporting/nice_region_error/trait_impl_difference.rs Outdated
@estebank
estebankforce-pushed the trait-impl-lt-mismatch branch from 0e57ace to be07592CompareOctober 4, 2019 03:02
@estebank

estebank commented Oct 4, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @nikomatsakis

estebank
estebank commented Oct 8, 2019
View reviewed changes
Comment threadsrc/librustc/infer/error_reporting/nice_region_error/trait_impl_difference.rs Outdated
@bors

This comment has been minimized.

Sign in to view
@estebank
estebankforce-pushed the trait-impl-lt-mismatch branch from 0c58dbf to 1e95b5cCompareOctober 15, 2019 17:36
@rust-highfive

This comment has been minimized.

Sign in to view
estebank
estebank commented Oct 15, 2019
View reviewed changes
Comment threadsrc/test/ui/reject-specialized-drops-8142.stderr Outdated
@JohnCSimon

JohnCSimon commented Oct 26, 2019

Copy link
Copy Markdown

Ping from triage:

@nikomatsakis Can you please review this PR? Thanks
CC: @estebank

@nikomatsakis

nikomatsakis commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

@bors r+

nice patch, @estebank

@bors

bors commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 3aba2d0 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 28, 2019
@JohnTitor
Rollup merge ofrust-lang#65068- estebank:trait-impl-lt-mismatch, r=…
05ff8db
…nikomatsakis
Custom lifetime error for `impl` item doesn't conform to `trait`
Partly addresses rust-lang#42706, rust-lang#41343, fixrust-lang#40900.
@JohnTitorJohnTitor mentioned this pull request Oct 28, 2019
Closed
@bors

bors commented Oct 29, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3aba2d0 with merge e097c19d6d8d9564b54923c2903baad9a990bbb2...

Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
@Centril
Rollup merge ofrust-lang#65068- estebank:trait-impl-lt-mismatch, r=…
1437592
…nikomatsakis
Custom lifetime error for `impl` item doesn't conform to `trait`
Partly addresses rust-lang#42706, rust-lang#41343, fixrust-lang#40900.
@CentrilCentril mentioned this pull request Oct 29, 2019
Closed
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 29, 2019
@borsbors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2019
@estebank
estebankforce-pushed the trait-impl-lt-mismatch branch from 3aba2d0 to 213fd1fCompareOctober 29, 2019 18:32
@estebank

estebank commented Oct 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

Made that test ignore x86 targets to get around different platform output discrepancies when a std span isn't found. There's a ticket open for that already.

@bors

bors commented Oct 29, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 213fd1f has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 30, 2019
@tmandry
Rollup merge ofrust-lang#65068- estebank:trait-impl-lt-mismatch, r=…
ab9b789
…nikomatsakis
Custom lifetime error for `impl` item doesn't conform to `trait`
Partly addresses rust-lang#42706, rust-lang#41343, fixrust-lang#40900.
@tmandrytmandry mentioned this pull request Oct 30, 2019
Closed
@bors

bors commented Oct 30, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 213fd1f with merge 0b7e28a...

bors added a commit that referenced this pull request Oct 30, 2019
@bors
Auto merge of#65068- estebank:trait-impl-lt-mismatch, r=nikomatsakis
0b7e28a
Custom lifetime error for `impl` item doesn't conform to `trait`
Partly addresses #42706, #41343, fix#40900.
@bors

bors commented Oct 30, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 0b7e28a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2019
@bors
bors merged commit 213fd1f into rust-lang:masterOct 30, 2019
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Nov 2, 2019
Closed
@estebankestebank mentioned this pull request Nov 14, 2019
Closed
@estebank
estebank deleted the trait-impl-lt-mismatch branch November 9, 2023 05:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error message for inferred lifetime failure isn't great

7 participants

@estebank@rust-highfive@bors@JohnCSimon@nikomatsakis@Centril@zackmdavis