Uh oh!
There was an error while loading. Please reload this page.
Optimize integral pattern matching - #65089
Merged
bors merged 5 commits intoOct 6, 2019
Merged
Conversation
This reduces the number of call sites for `constructor_intersects_pattern()` from two to one, which the next commit will take advantage of.
This is a 2% instruction count win on `unicode_normalization-check-clean`.
This commit moves a lot of code around but doesn't change functionality at all. The main goal was for `from_pat()` to no longer call `from_ctor()`. The increase in inlining resulted in less function call overhead, for a 3% instruction count win on `unicode_normalization-check-clean`.
The `if let Some(val) = value.try_eval_bits(...)` branch in `from_const()` is very hot for the `unicode_normalization` benchmark. This commit introduces a special-case alternative for scalars that avoids `try_eval_bits()` and all the functions it calls (`Const::eval()`, `ConstValue::try_to_bits()`, `ConstValue::try_to_scalar()`, and `Scalar::to_bits()`), instead extracting the result immediately. The type and value checking done by `Scalar::to_bits()` is replicated by moving it into a new function `Scalar::check_raw()` and using that new function in the special case. PR rust-lang#64673 introduced some special-case handling of scalar types in `Const::try_eval_bits()`. This handling is now moved out of that function into the new `IntRange::integral_size_and_signed_bias` function. This commit reduces the instruction count for `unicode_normalization-check-clean` by about 10%.
`filter_map()` is less general, but more efficient, and has the same effect in this case. This commit reduces the instruction count for `unicode_normalization-check-clean` by about 2%.
fbstj
reviewed
Oct 4, 2019
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
Changes look good to me; they're all just shuffling code around so we can probably land this without additional review, but cc @oli-obk
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
reviewed
Oct 4, 2019
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Oct 4, 2019
Contributor
r? @varkor |
Centril
commented
Oct 4, 2019
Contributor
oops; r? @Mark-Simulacrum but cc @varkor :) |
Mark-Simulacrum
commented
Oct 5, 2019
Member
@bors r+ rollup=never since perf |
bors
commented
Oct 5, 2019
Collaborator
📌 Commit 2a3a544 has been approved by |
bors
commented
Oct 6, 2019
Collaborator
bors added a commit
that referenced
this pull request
Oct 6, 2019
…, r=Mark-Simulacrum Optimize integral pattern matching Various improvements to integral pattern matching. Together they reduce instruction counts for `unicode_normalization-check-clean` by about 16%. r? @Mark-Simulacrum
bors
commented
Oct 6, 2019
Collaborator
☀️ Test successful - checks-azure |
| Integer::from_attr(&tcx, UnsignedInt(uty)).size() | ||
| } | ||
| _ => tcx.layout_of(param_env.with_reveal_all().and(ty)).ok()?.size, | ||
| }; |
Member
There was a problem hiding this comment.
A quick grep shows a few more sites that call layout_of just to get the size or alignment (and there's likely more but split across multiple lines). So it might still be worth having size_and_align_of(Ty<'tcx>) somewhere with an optimization like this -- maybe?
Contributor
There was a problem hiding this comment.
yea, this could just be a method on TyCtxt
Nadrieril added a commit
to Nadrieril/rust
that referenced
this pull request
Oct 18, 2019
This reverses changes from rust-lang#65089, but I need this temporarily for rebase to be tractable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various improvements to integral pattern matching. Together they reduce instruction counts for
unicode_normalization-check-cleanby about 16%.r? @Mark-Simulacrum