Skip to content

Add long error explanation for E0561 - #65098

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:long-err-explanation-E0561
Oct 8, 2019
Merged

Add long error explanation for E0561#65098
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:long-err-explanation-E0561

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Oct 4, 2019

Copy link
Copy Markdown
Member

Part of #61137

@rust-highfive

rust-highfive commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2019
@GuillaumeGomezGuillaumeGomez mentioned this pull request Oct 4, 2019
Closed
100 tasks
@eddyb

eddyb commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

r? @estebank

@rust-highfiverust-highfive assigned estebank and unassigned eddybOct 4, 2019
Centril
Centril reviewed Oct 4, 2019
View reviewed changes
Comment threadsrc/librustc_passes/error_codes.rs Outdated
Comment threadsrc/librustc_passes/error_codes.rs Outdated
Comment threadsrc/librustc_passes/error_codes.rs Outdated
Comment threadsrc/librustc_passes/error_codes.rs Outdated
@Centril

Centril commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

r? @Centril

@rust-highfiverust-highfive assigned Centril and unassigned estebankOct 4, 2019
estebank
estebank reviewed Oct 4, 2019
View reviewed changes
Comment threadsrc/librustc_passes/error_codes.rs Outdated
estebank
estebank reviewed Oct 4, 2019
View reviewed changes
Comment threadsrc/librustc_passes/error_codes.rs Outdated
@GuillaumeGomez
GuillaumeGomezforce-pushed the long-err-explanation-E0561 branch from bd65439 to eee64f2CompareOctober 5, 2019 09:42
@GuillaumeGomez

GuillaumeGomez commented Oct 5, 2019

Copy link
Copy Markdown
MemberAuthor

Thanks for the reviews! Updated.

Centril
Centril reviewed Oct 6, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with these suggestions applied

Comment threadsrc/librustc_passes/error_codes.rs Outdated
Comment threadsrc/librustc_passes/error_codes.rs Outdated
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2019
@bors

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomezforce-pushed the long-err-explanation-E0561 branch from eee64f2 to b28c2bbCompareOctober 7, 2019 09:18
@GuillaumeGomez
GuillaumeGomezforce-pushed the long-err-explanation-E0561 branch from b28c2bb to 8dd0008CompareOctober 7, 2019 09:20
@GuillaumeGomez

GuillaumeGomez commented Oct 7, 2019

Copy link
Copy Markdown
MemberAuthor

Updated.

@Centril

Centril commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 8dd0008 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
@Centril
Rollup merge ofrust-lang#65098- GuillaumeGomez:long-err-explanation…
73685ec
…-E0561, r=Centril
Add long error explanation for E0561
Part of rust-lang#61137
@CentrilCentril mentioned this pull request Oct 8, 2019
Merged
bors added a commit that referenced this pull request Oct 8, 2019
@bors
Auto merge of#65196- Centril:rollup-q06lcxm, r=Centril
1e1f25e
Rollup of 8 pull requests
Successful merges:
- #64726 (rewrite documentation for unimplemented! to clarify use)
- #65040 (syntax: more cleanups in item and function signature parsing)
- #65046 (Make `Cell::new` method come first in documentation)
- #65098 (Add long error explanation for E0561)
- #65150 (Suggest dereferencing boolean reference when used in 'if' or 'while')
- #65154 (Fix const generic arguments not displaying in types mismatch diagnostic)
- #65181 (fix bug in folding for constants)
- #65187 (use 'invalid argument' for vxWorks)
Failed merges:
- #65179 (Add long error explanation for E0567)
r? @ghost
@bors
bors merged commit 8dd0008 into rust-lang:masterOct 8, 2019
@GuillaumeGomez
GuillaumeGomez deleted the long-err-explanation-E0561 branch October 8, 2019 14:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank left review comments
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-highfive@eddyb@Centril@bors@estebank