implement FromIterator<char> for Box<str> by Duddino · Pull Request #65168 · rust-lang/rust

Duddino · 2019-10-06T15:53:02Z

Sorry in advance if I did something wrong, it's my first pull request

rust-highfive · 2019-10-06T15:53:12Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TimNN (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive · 2019-10-06T16:01:21Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-06T15:53:42.6358971Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-06T15:53:42.6559281Z ##[command]git config gc.auto 0
2019-10-06T15:53:42.6657048Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-06T15:53:42.6740853Z ##[command]git config --get-all http.proxy
2019-10-06T15:53:42.6945186Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-06T16:00:29.4289881Z == clock drift check ==
2019-10-06T16:00:29.4307218Z local time: Sun Oct 6 16:00:29 UTC 2019
2019-10-06T16:00:29.5837155Z network time: Sun, 06 Oct 2019 16:00:29 GMT
2019-10-06T16:00:29.5840437Z == end clock drift check ==
2019-10-06T16:00:37.6262314Z ##[error]Bash exited with code '1'.
2019-10-06T16:00:37.6305104Z ##[section]Starting: Checkout
2019-10-06T16:00:37.6306766Z ==============================================================================
2019-10-06T16:00:37.6307323Z Task : Get sources
2019-10-06T16:00:37.6307370Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-06T16:10:45Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-06T16:03:02.5739388Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-06T16:03:02.5933040Z ##[command]git config gc.auto 0
2019-10-06T16:03:02.6020459Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-06T16:03:02.6091187Z ##[command]git config --get-all http.proxy
2019-10-06T16:03:02.6262557Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-06T16:09:11.8655881Z == clock drift check ==
2019-10-06T16:09:11.8681260Z local time: Sun Oct 6 16:09:11 UTC 2019
2019-10-06T16:09:12.0170843Z network time: Sun, 06 Oct 2019 16:09:12 GMT
2019-10-06T16:09:12.0176090Z == end clock drift check ==
2019-10-06T16:09:20.4458206Z ##[error]Bash exited with code '1'.
2019-10-06T16:09:20.4526620Z ##[section]Starting: Checkout
2019-10-06T16:09:20.4528609Z ==============================================================================
2019-10-06T16:09:20.4528667Z Task : Get sources
2019-10-06T16:09:20.4528735Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

sinkuu · 2019-10-06T16:18:01Z

+ let mut buf = String::new();
+ buf.extend(iter);
+ buf.into_boxed_str()


Can the string creation reuse String::from_iter?
String::from_iter(iter).into_boxed_str()

You're right, thanks!

rust-highfive · 2019-10-06T18:20:23Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-06T16:55:34.3795214Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-06T16:55:34.3992419Z ##[command]git config gc.auto 0
2019-10-06T16:55:34.4052621Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-06T16:55:34.4113293Z ##[command]git config --get-all http.proxy
2019-10-06T16:55:34.4256042Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-06T17:57:24.4047741Z .................................................................................................... 1500/9109
2019-10-06T17:57:31.3778794Z .................................................................................................... 1600/9109
2019-10-06T17:57:40.4022758Z .................................................................................................... 1700/9109
2019-10-06T17:57:49.7205028Z ........i...............i........................................................................... 1800/9109
2019-10-06T17:57:56.8404279Z ...................................................................................................i 1900/9109
2019-10-06T17:58:12.7674513Z iiii................................................................................................ 2000/9109
2019-10-06T17:58:21.4722820Z .................................................................................................... 2200/9109
2019-10-06T17:58:24.0866362Z .................................................................................................... 2300/9109
2019-10-06T17:58:30.3342171Z .................................................................................................... 2400/9109
2019-10-06T17:58:35.8787834Z .................................................................................................... 2500/9109
---
2019-10-06T18:01:28.6173611Z ........................................................................................i........... 4700/9109
2019-10-06T18:01:36.4269225Z ....i............................................................................................... 4800/9109
2019-10-06T18:01:47.0382471Z .................................................................................................... 4900/9109
2019-10-06T18:01:52.6834284Z .................................................................................................... 5000/9109
2019-10-06T18:02:04.5987666Z ..................................................................................ii.ii............. 5100/9109
2019-10-06T18:02:14.0999660Z .................................................................................................... 5300/9109
2019-10-06T18:02:24.2869929Z .................................................................................................... 5400/9109
2019-10-06T18:02:30.9315805Z ................................................i................................................... 5500/9109
2019-10-06T18:02:37.8601550Z .................................................................................................... 5600/9109
2019-10-06T18:02:37.8601550Z .................................................................................................... 5600/9109
2019-10-06T18:02:48.0726435Z .................................................................................................... 5700/9109
2019-10-06T18:02:55.9549929Z .............................................ii...i..ii...........i................................. 5800/9109
2019-10-06T18:03:21.4736496Z .................................................................................................... 6000/9109
2019-10-06T18:03:31.4806253Z .................................................................................................... 6100/9109
2019-10-06T18:03:31.4806253Z .................................................................................................... 6100/9109
2019-10-06T18:03:42.7356265Z ...................................................i..ii............................................ 6200/9109
2019-10-06T18:04:06.9385459Z .................................................................................................... 6400/9109
2019-10-06T18:04:09.0833711Z ...........i........................................................................................ 6500/9109
2019-10-06T18:04:11.3400096Z ....................................................................................i............... 6600/9109
2019-10-06T18:04:14.0736436Z .................................................................................................... 6700/9109
---
2019-10-06T18:08:49.6640625Z finished in 5.455
2019-10-06T18:08:49.6810650Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T18:08:49.8677001Z 2019-10-06T18:08:49.8677331Z running 150 tests
2019-10-06T18:08:53.0599664Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-10-06T18:08:55.0472849Z ..iiii..............i.........iii.i.......ii......
2019-10-06T18:08:55.0476550Z 2019-10-06T18:08:55.0478064Z finished in 5.366
2019-10-06T18:08:55.0662716Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T18:08:55.2377994Z ---
2019-10-06T18:08:57.3072562Z finished in 2.240
2019-10-06T18:08:57.3256803Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T18:08:57.4910112Z 2019-10-06T18:08:57.4910952Z running 9 tests
2019-10-06T18:08:57.4911968Z iiiiiiiii
2019-10-06T18:08:57.4912803Z 2019-10-06T18:08:57.4912950Z finished in 0.165
2019-10-06T18:08:57.5133983Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T18:08:57.7071406Z ---
2019-10-06T18:09:15.8678103Z finished in 18.354
2019-10-06T18:09:15.8900489Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T18:09:16.0778234Z 2019-10-06T18:09:16.0778501Z running 123 tests
2019-10-06T18:09:40.7647135Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-06T18:09:45.5088843Z i.i.i......iii.i.....ii
2019-10-06T18:09:45.5089460Z 2019-10-06T18:09:45.5089512Z finished in 29.619
2019-10-06T18:09:45.5102385Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T18:09:45.5103087Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-06T18:19:30.7008010Z 2019-10-06T18:19:31.3288806Z error[E0308]: mismatched types
2019-10-06T18:19:31.3289199Z --> <::core::macros::assert_eq macros>:7:34
2019-10-06T18:19:31.3289428Z |
2019-10-06T18:19:31.3289722Z 1 | / ($ left : expr, $ right : expr) =>
2019-10-06T18:19:31.3290128Z 2 | | ({
2019-10-06T18:19:31.3290447Z 3 | | match (& $ left, & $ right)
2019-10-06T18:19:31.3291284Z ... |
2019-10-06T18:19:31.3291284Z ... |
2019-10-06T18:19:31.3291595Z 7 | | if ! (* left_val == * right_val)
2019-10-06T18:19:31.3292672Z | | |
2019-10-06T18:19:31.3293251Z | | expected enum `core::option::Option`, found char
2019-10-06T18:19:31.3293251Z | | expected enum `core::option::Option`, found char
2019-10-06T18:19:31.3293766Z | | help: try using a variant of the expected type: `core::prelude::v1::Some(*right_val)`
2019-10-06T18:19:31.3294387Z 35 | | }
2019-10-06T18:19:31.3294699Z 36 | | }) ;
2019-10-06T18:19:31.3295037Z | |_____- in this expansion of `assert_eq!`
2019-10-06T18:19:31.3295454Z | 2019-10-06T18:19:31.3295454Z | 2019-10-06T18:19:31.3295701Z ::: src/liballoc/tests.rs:162:5
2019-10-06T18:19:31.3295906Z |
2019-10-06T18:19:31.3296206Z 162 | assert_eq!(string.chars().nth(5), '☺');
2019-10-06T18:19:31.3296744Z |
2019-10-06T18:19:31.3297031Z = note: expected type `core::option::Option<char>`
2019-10-06T18:19:31.3297260Z found type `char`
2019-10-06T18:19:31.3297293Z ---
2019-10-06T18:20:18.9632768Z == clock drift check ==
2019-10-06T18:20:18.9648604Z local time: Sun Oct 6 18:20:18 UTC 2019
2019-10-06T18:20:19.0523639Z network time: Sun, 06 Oct 2019 18:20:19 GMT
2019-10-06T18:20:19.0526199Z == end clock drift check ==
2019-10-06T18:20:19.6188241Z ##[error]Bash exited with code '1'.
2019-10-06T18:20:19.6237880Z ##[section]Starting: Checkout
2019-10-06T18:20:19.6239731Z ==============================================================================
2019-10-06T18:20:19.6239810Z Task : Get sources
2019-10-06T18:20:19.6239862Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-06T19:59:15Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-06T18:33:23.5295197Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-06T18:33:24.2672589Z ##[command]git config gc.auto 0
2019-10-06T18:33:24.2678865Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-06T18:33:24.2684363Z ##[command]git config --get-all http.proxy
2019-10-06T18:33:24.2687924Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-06T19:35:43.9489387Z .................................................................................................... 1500/9109
2019-10-06T19:35:50.8760596Z .................................................................................................... 1600/9109
2019-10-06T19:36:00.0317296Z .................................................................................................... 1700/9109
2019-10-06T19:36:09.4802020Z ........i...............i........................................................................... 1800/9109
2019-10-06T19:36:16.8007764Z ...................................................................................................i 1900/9109
2019-10-06T19:36:33.0577284Z iiii................................................................................................ 2000/9109
2019-10-06T19:36:42.0812361Z .................................................................................................... 2200/9109
2019-10-06T19:36:44.7453372Z .................................................................................................... 2300/9109
2019-10-06T19:36:50.9705104Z .................................................................................................... 2400/9109
2019-10-06T19:36:56.7424684Z .................................................................................................... 2500/9109
---
2019-10-06T19:39:54.5503064Z ........................................................................................i........... 4700/9109
2019-10-06T19:40:02.4795725Z ....i............................................................................................... 4800/9109
2019-10-06T19:40:13.2626946Z .................................................................................................... 4900/9109
2019-10-06T19:40:19.1445147Z .................................................................................................... 5000/9109
2019-10-06T19:40:31.3719778Z ..................................................................................ii.ii............. 5100/9109
2019-10-06T19:40:40.9163760Z .................................................................................................... 5300/9109
2019-10-06T19:40:51.2148593Z .................................................................................................... 5400/9109
2019-10-06T19:40:58.0389167Z ................................................i................................................... 5500/9109
2019-10-06T19:41:05.4116375Z .................................................................................................... 5600/9109
2019-10-06T19:41:05.4116375Z .................................................................................................... 5600/9109
2019-10-06T19:41:15.7407855Z .................................................................................................... 5700/9109
2019-10-06T19:41:23.8155783Z .............................................ii...i..ii...........i................................. 5800/9109
2019-10-06T19:41:49.3802538Z .................................................................................................... 6000/9109
2019-10-06T19:41:58.7805931Z .................................................................................................... 6100/9109
2019-10-06T19:41:58.7805931Z .................................................................................................... 6100/9109
2019-10-06T19:42:11.7334712Z ...................................................i..ii............................................ 6200/9109
2019-10-06T19:42:36.3365412Z .................................................................................................... 6400/9109
2019-10-06T19:42:38.5584019Z ...........i........................................................................................ 6500/9109
2019-10-06T19:42:40.8239795Z ....................................................................................i............... 6600/9109
2019-10-06T19:42:43.7293231Z .................................................................................................... 6700/9109
---
2019-10-06T19:47:23.0165234Z finished in 5.659
2019-10-06T19:47:23.0369745Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T19:47:23.2055298Z 2019-10-06T19:47:23.2055713Z running 150 tests
2019-10-06T19:47:26.4435666Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-10-06T19:47:28.4530406Z ..iiii..............i.........iii.i.......ii......
2019-10-06T19:47:28.4534999Z 2019-10-06T19:47:28.4537380Z finished in 5.417
2019-10-06T19:47:28.4725426Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T19:47:28.6382736Z ---
2019-10-06T19:47:30.6899649Z finished in 2.217
2019-10-06T19:47:30.7096751Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T19:47:30.8732380Z 2019-10-06T19:47:30.8732708Z running 9 tests
2019-10-06T19:47:30.8734239Z iiiiiiiii
2019-10-06T19:47:30.8734883Z 2019-10-06T19:47:30.8734930Z finished in 0.163
2019-10-06T19:47:30.8932841Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T19:47:31.0639710Z ---
2019-10-06T19:47:49.2722465Z finished in 18.379
2019-10-06T19:47:49.2958514Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T19:47:49.4612528Z 2019-10-06T19:47:49.4612925Z running 123 tests
2019-10-06T19:48:14.5967189Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-06T19:48:19.4279386Z i.i.i......iii.i.....ii
2019-10-06T19:48:19.4282912Z 2019-10-06T19:48:19.4283244Z finished in 30.132
2019-10-06T19:48:19.4291726Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T19:48:19.4292315Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-06T19:59:10.2403512Z == clock drift check ==
2019-10-06T19:59:10.2418616Z local time: Sun Oct 6 19:59:10 UTC 2019
2019-10-06T19:59:10.4082460Z network time: Sun, 06 Oct 2019 19:59:10 GMT
2019-10-06T19:59:10.4084899Z == end clock drift check ==
2019-10-06T19:59:10.9217365Z ##[error]Bash exited with code '1'.
2019-10-06T19:59:10.9268575Z ##[section]Starting: Checkout
2019-10-06T19:59:10.9270730Z ==============================================================================
2019-10-06T19:59:10.9270788Z Task : Get sources
2019-10-06T19:59:10.9270850Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-06T21:31:37Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-06T20:03:11.6826923Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-06T20:03:11.7153575Z ##[command]git config gc.auto 0
2019-10-06T20:03:11.7238639Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-06T20:03:11.7302178Z ##[command]git config --get-all http.proxy
2019-10-06T20:03:11.7458838Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-06T21:07:21.5082380Z .................................................................................................... 1500/9109
2019-10-06T21:07:28.7271975Z .................................................................................................... 1600/9109
2019-10-06T21:07:38.1494238Z .................................................................................................... 1700/9109
2019-10-06T21:07:47.9269679Z ........i...............i........................................................................... 1800/9109
2019-10-06T21:07:55.4455982Z ...................................................................................................i 1900/9109
2019-10-06T21:08:12.2597123Z iiii................................................................................................ 2000/9109
2019-10-06T21:08:21.5819355Z .................................................................................................... 2200/9109
2019-10-06T21:08:24.3449109Z .................................................................................................... 2300/9109
2019-10-06T21:08:30.9897454Z .................................................................................................... 2400/9109
2019-10-06T21:08:36.7811452Z .................................................................................................... 2500/9109
---
2019-10-06T21:11:37.7810042Z ........................................................................................i........... 4700/9109
2019-10-06T21:11:45.9718488Z ....i............................................................................................... 4800/9109
2019-10-06T21:11:57.0594994Z .................................................................................................... 4900/9109
2019-10-06T21:12:03.0571945Z .................................................................................................... 5000/9109
2019-10-06T21:12:15.7154442Z ..................................................................................ii.ii............. 5100/9109
2019-10-06T21:12:25.4970823Z .................................................................................................... 5300/9109
2019-10-06T21:12:36.0613858Z .................................................................................................... 5400/9109
2019-10-06T21:12:43.2199806Z ................................................i................................................... 5500/9109
2019-10-06T21:12:50.5112122Z .................................................................................................... 5600/9109
2019-10-06T21:12:50.5112122Z .................................................................................................... 5600/9109
2019-10-06T21:13:01.4821153Z .................................................................................................... 5700/9109
2019-10-06T21:13:09.7608955Z .............................................ii...i..ii...........i................................. 5800/9109
2019-10-06T21:13:36.3062445Z .................................................................................................... 6000/9109
2019-10-06T21:13:45.9286667Z .................................................................................................... 6100/9109
2019-10-06T21:13:45.9286667Z .................................................................................................... 6100/9109
2019-10-06T21:13:59.7518468Z ...................................................i..ii............................................ 6200/9109
2019-10-06T21:14:25.3344005Z .................................................................................................... 6400/9109
2019-10-06T21:14:27.6380207Z ...........i........................................................................................ 6500/9109
2019-10-06T21:14:30.0443562Z ....................................................................................i............... 6600/9109
2019-10-06T21:14:32.9525437Z .................................................................................................... 6700/9109
---
2019-10-06T21:19:22.0341400Z finished in 5.712
2019-10-06T21:19:22.0536020Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T21:19:22.2348956Z 2019-10-06T21:19:22.2349572Z running 150 tests
2019-10-06T21:19:25.5984797Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-10-06T21:19:27.7165472Z ..iiii..............i.........iii.i.......ii......
2019-10-06T21:19:27.7166104Z 2019-10-06T21:19:27.7172796Z finished in 5.663
2019-10-06T21:19:27.7370000Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T21:19:27.9049079Z ---
2019-10-06T21:19:30.0582201Z finished in 2.321
2019-10-06T21:19:30.0792817Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T21:19:30.2509733Z 2019-10-06T21:19:30.2510583Z running 9 tests
2019-10-06T21:19:30.2511780Z iiiiiiiii
2019-10-06T21:19:30.2513114Z 2019-10-06T21:19:30.2513310Z finished in 0.171
2019-10-06T21:19:30.2707782Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T21:19:30.4428783Z ---
2019-10-06T21:19:49.4584482Z finished in 19.187
2019-10-06T21:19:49.4847450Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T21:19:49.6563089Z 2019-10-06T21:19:49.6564718Z running 123 tests
2019-10-06T21:20:15.9628352Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-06T21:20:21.0469040Z i.i.i......iii.i.....ii
2019-10-06T21:20:21.0469639Z 2019-10-06T21:20:21.0473959Z finished in 31.562
2019-10-06T21:20:21.0483593Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-06T21:20:21.0484022Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-06T21:31:32.0573916Z tests::box_str_from_iter
2019-10-06T21:31:32.0573948Z 2019-10-06T21:31:32.0578624Z test result: FAILED. 106 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-10-06T21:31:32.0578750Z 2019-10-06T21:31:32.0600414Z error: test failed, to rerun pass '-p alloc --lib'
2019-10-06T21:31:32.0622372Z 2019-10-06T21:31:32.0623229Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--" "--quiet"
2019-10-06T21:31:32.0623532Z expected success, got: exit code: 101
2019-10-06T21:31:32.0623719Z 2019-10-06T21:31:32.0623719Z 2019-10-06T21:31:32.0623804Z 2019-10-06T21:31:32.0636780Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-06T21:31:32.0636874Z Build completed unsuccessfully in 1:20:52
2019-10-06T21:31:32.0695742Z == clock drift check ==
2019-10-06T21:31:32.0713136Z local time: Sun Oct 6 21:31:32 UTC 2019
2019-10-06T21:31:32.1587474Z network time: Sun, 06 Oct 2019 21:31:32 GMT
2019-10-06T21:31:32.1591259Z == end clock drift check ==
2019-10-06T21:31:32.8082844Z ##[error]Bash exited with code '1'.
2019-10-06T21:31:32.8131435Z ##[section]Starting: Checkout
2019-10-06T21:31:32.8133136Z ==============================================================================
2019-10-06T21:31:32.8133187Z Task : Get sources
2019-10-06T21:31:32.8133247Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JohnCSimon · 2019-10-12T20:31:21Z

Ping from triage.
@TimNN Can you please review this PR?
@sinkuu
Thanks!

TimNN · 2019-10-14T16:15:38Z

Re-assigning to the libs team:

r? @KodrAus

Mark-Simulacrum · 2019-10-18T13:45:02Z

 }
 }
+
+#[unstable(feature = "box_str_from_iter", issue = "0")]


impls are going to be insta-stable, you can probably make this just be stable with the same feature name

rust-highfive · 2019-10-18T19:44:05Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-18T19:32:36.0474132Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-18T19:32:36.0691695Z ##[command]git config gc.auto 0
2019-10-18T19:32:36.0772512Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-18T19:32:36.0848380Z ##[command]git config --get-all http.proxy
2019-10-18T19:32:36.0998993Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-18T19:38:18.1115921Z Successfully built ef0ffffa25ef
2019-10-18T19:38:18.1930419Z Successfully tagged rust-ci:latest
2019-10-18T19:38:18.2440103Z Built container sha256:ef0ffffa25ef151593a009680b55f82e70577174e8f730eeea5b38f5b10f3768
2019-10-18T19:38:18.2458464Z Uploading finished image to https://rust-lang-ci-sccache2.s3.amazonaws.com/docker/590c864a5f2335de0a8287407f9a96030510ec86a676b9b48333a6a037ff1c9ca74007b9ad184866d613750a3d2a1a88c9ad4e657c82d0b1a088ee62c541c4ca
2019-10-18T19:39:21.4517441Z upload failed: - to s3://rust-lang-ci-sccache2/docker/590c864a5f2335de0a8287407f9a96030510ec86a676b9b48333a6a037ff1c9ca74007b9ad184866d613750a3d2a1a88c9ad4e657c82d0b1a088ee62c541c4ca An error occurred (InvalidAccessKeyId) when calling the CreateMultipartUpload operation: The AWS Access Key Id you provided does not exist in our records.
2019-10-18T19:39:22.0843409Z [CI_JOB_NAME=x86_64-gnu-llvm-6.0]
2019-10-18T19:39:22.0870780Z == clock drift check ==
2019-10-18T19:39:22.0900324Z local time: Fri Oct 18 19:39:22 UTC 2019
2019-10-18T19:39:22.3521868Z network time: Fri, 18 Oct 2019 19:39:22 GMT
---
2019-10-18T19:43:30.7860507Z Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
2019-10-18T19:43:31.3148197Z Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
2019-10-18T19:43:37.1604810Z Compiling rustc-std-workspace-core v1.99.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-10-18T19:43:39.3405853Z Compiling alloc v0.0.0 (/checkout/src/liballoc)
2019-10-18T19:43:39.8142029Z error[E0541]: unknown meta item 'issue'
2019-10-18T19:43:39.8142506Z --> src/liballoc/boxed.rs:1097:41
2019-10-18T19:43:39.8142843Z |
2019-10-18T19:43:39.8143247Z 1097 | #[stable(feature = "box_str_from_iter", issue = "0", since = "1.39.0")]
2019-10-18T19:43:39.8145724Z | ^^^^^^^^^^^ expected one of `since`, `note`
2019-10-18T19:43:40.0079683Z Compiling cfg-if v0.1.8
2019-10-18T19:43:40.0504724Z Compiling rustc-demangle v0.1.16
2019-10-18T19:43:41.0479706Z error: aborting due to previous error
2019-10-18T19:43:41.0480217Z ---
2019-10-18T19:43:41.5699258Z local time: Fri Oct 18 19:43:41 UTC 2019
2019-10-18T19:43:41.7076146Z network time: Fri, 18 Oct 2019 19:43:41 GMT
2019-10-18T19:43:41.7081689Z == end clock drift check ==
2019-10-18T19:43:44.3507720Z 2019-10-18T19:43:44.3683602Z ##[error]Bash exited with code '1'.
2019-10-18T19:43:44.3723980Z ##[section]Starting: Checkout
2019-10-18T19:43:44.3725859Z ==============================================================================
2019-10-18T19:43:44.3725952Z Task : Get sources
2019-10-18T19:43:44.3726019Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Duddino · 2019-10-18T19:58:12Z

What should I write for "since"? 1.39.0 doesn't work

bluss · 2019-10-19T09:49:13Z

It should be 1.40.0

rust-highfive · 2019-10-19T12:04:52Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-19T11:57:51.4492400Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-19T11:57:51.4717202Z ##[command]git config gc.auto 0
2019-10-19T11:57:51.4789929Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-19T11:57:51.4845719Z ##[command]git config --get-all http.proxy
2019-10-19T11:57:51.4992962Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-19T12:03:29.0434107Z Checking rustc-std-workspace-core v1.99.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-10-19T12:03:31.7440849Z Checking alloc v0.0.0 (/checkout/src/liballoc)
2019-10-19T12:03:32.0858280Z Checking cfg-if v0.1.8
2019-10-19T12:03:32.1291855Z Checking rustc-demangle v0.1.16
2019-10-19T12:03:32.2309202Z error[E0541]: unknown meta item 'issue'
2019-10-19T12:03:32.2309682Z --> src/liballoc/boxed.rs:1107:41
2019-10-19T12:03:32.2309916Z |
2019-10-19T12:03:32.2310396Z 1107 | #[stable(feature = "box_str_from_iter", issue = "0", since = "1.40.0")]
2019-10-19T12:03:32.2310919Z | ^^^^^^^^^^^ expected one of `since`, `note`
2019-10-19T12:03:33.1428091Z Checking panic_abort v0.0.0 (/checkout/src/libpanic_abort)
2019-10-19T12:03:33.1428690Z Checking backtrace v0.3.37
2019-10-19T12:03:33.4506992Z error: aborting due to previous error
2019-10-19T12:03:33.4507581Z ---
2019-10-19T12:03:33.4845292Z local time: Sat Oct 19 12:03:33 UTC 2019
2019-10-19T12:03:33.6477457Z network time: Sat, 19 Oct 2019 12:03:33 GMT
2019-10-19T12:03:33.6482523Z == end clock drift check ==
2019-10-19T12:03:38.4444458Z 2019-10-19T12:03:38.4554207Z ##[error]Bash exited with code '1'.
2019-10-19T12:03:38.4588600Z ##[section]Starting: Checkout
2019-10-19T12:03:38.4590504Z ==============================================================================
2019-10-19T12:03:38.4590558Z Task : Get sources
2019-10-19T12:03:38.4590604Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-19T12:16:45Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-19T12:09:38.0280871Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-19T12:09:38.0480073Z ##[command]git config gc.auto 0
2019-10-19T12:09:38.0577529Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-19T12:09:38.0656448Z ##[command]git config --get-all http.proxy
2019-10-19T12:09:38.0815032Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65168/merge:refs/remotes/pull/65168/merge
---
2019-10-19T12:15:47.1959327Z local time: Sat Oct 19 12:15:47 UTC 2019
2019-10-19T12:15:47.3596689Z network time: Sat, 19 Oct 2019 12:15:47 GMT
2019-10-19T12:15:47.3601001Z == end clock drift check ==
2019-10-19T12:15:50.0931355Z 2019-10-19T12:15:50.1084358Z ##[error]Bash exited with code '1'.
2019-10-19T12:15:50.1141705Z ##[section]Starting: Checkout
2019-10-19T12:15:50.1145045Z ==============================================================================
2019-10-19T12:15:50.1145109Z Task : Get sources
2019-10-19T12:15:50.1145155Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

joelpalmer · 2019-10-28T13:20:02Z

Ping from Triage: any update @Duddino?

Duddino · 2019-10-29T14:09:22Z

I'm going to fix it later this day

KodrAus · 2019-11-04T00:31:58Z

+
+#[test]
+fn box_str_from_iter(){
+ let iter = (0..100).map(|_|{'☺'});


KodrAus · 2019-11-04T00:35:09Z

 //!
 //! # Examples
 //!
+//! A pointer type for heap allocation.


It looks like our docs might still be a little confused here, because they've changed on master since you fixed them up.
Would you like to try squashing your 12 commits down and rebase on master?

sfackler · 2019-11-04T00:39:04Z

Box is #[fundamental] - I don't know if we can in practice add new impls to it.

RustyYato · 2019-11-05T05:59:41Z

@sfackler that should only be a concern for generic impls, because it could break downstream crates. This should be fine because it is just for Box<str>

JohnCSimon · 2019-11-09T06:24:51Z

Ping from Triage:
@Duddino - Can you address the comments from @sfackler and @KrishnaSannasi and squash+rebase on master
Cc: @KodrAus

thanks!

JohnCSimon · 2019-11-16T06:39:31Z

Pinging again from Triage:
@Duddino - Can you address the comments from @sfackler and @KrishnaSannasi and squash+rebase on master
Cc: @KodrAus

thanks!

JohnCSimon · 2019-11-24T00:23:45Z

Pinging once again from Triage:
@Duddino - Can you address the comments from @sfackler and @KrishnaSannasi and squash+rebase on master
Cc: @KodrAus

Thank you.

JohnCSimon · 2019-11-29T02:35:59Z

Unfortunately this PR has sat idle for awhile and I'm closing this as inactive
@Duddino - thanks for your contributions and feel free to re-open this when you like.

implement FromIterator<char> for Box<str>
c481236

rust-highfive assigned TimNN Oct 6, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2019

fixed trailing newline
a0a313c

DUDDINO RITARDATO added 2 commits October 6, 2019 18:12

added use crate::string::String
7192b0c

added use std::string::String
b268827

sinkuu reviewed Oct 6, 2019
View reviewed changes

Using String::from_iter
ab689ea

fixed test
048710a

bluss added the T-libs-api [DEPRECATED; DO NOT USE] label Oct 6, 2019

fixed unused import
0fad2a6

changed string.len() into string.chars().count()
c73c4b4

bluss mentioned this pull request Oct 8, 2019
Implement std::iter::FromIterator<char> for Box<str> #65163
Closed

rust-highfive assigned KodrAus and unassigned TimNN Oct 14, 2019

Mark-Simulacrum reviewed Oct 18, 2019
View reviewed changes

Making the implementation stable
f2f9eec

since 1.40.0
b10277a

removed issue
e773b20

KodrAus reviewed Oct 23, 2019
View reviewed changes

Comment threadsrc/liballoc/boxed.rs Outdated

Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2019

removed whitespaces
4ddbf8d

KodrAus reviewed Nov 4, 2019
View reviewed changes

JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 29, 2019

JohnCSimon closed this Nov 29, 2019

LukasKalbertodt mentioned this pull request Mar 18, 2020
impl FromIterator<char> for Box<str> #70094
Closed

Uh oh!

Uh oh!

Conversation

Duddino commented Oct 6, 2019

Uh oh!

rust-highfive commented Oct 6, 2019

Uh oh!

rust-highfive commented Oct 6, 2019

Uh oh!

rust-highfive commented Oct 6, 2019

Uh oh!

sinkuuOct 6, 2019

Choose a reason for hiding this comment

Uh oh!

DuddinoOct 6, 2019

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Oct 6, 2019

Uh oh!

rust-highfive commented Oct 6, 2019

Uh oh!

rust-highfive commented Oct 6, 2019

Uh oh!

JohnCSimon commented Oct 12, 2019

Uh oh!

TimNN commented Oct 14, 2019

Uh oh!

Mark-SimulacrumOct 18, 2019

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Oct 18, 2019

Uh oh!

Duddino commented Oct 18, 2019

Uh oh!

bluss commented Oct 19, 2019

Uh oh!

rust-highfive commented Oct 19, 2019

Uh oh!

rust-highfive commented Oct 19, 2019

Uh oh!

Uh oh!

joelpalmer commented Oct 28, 2019

Uh oh!

Duddino commented Oct 29, 2019

Uh oh!

KodrAusNov 4, 2019

Choose a reason for hiding this comment

Uh oh!

KodrAusNov 4, 2019

Choose a reason for hiding this comment

Uh oh!

sfackler commented Nov 4, 2019

Uh oh!

RustyYato commented Nov 5, 2019

Uh oh!

JohnCSimon commented Nov 9, 2019

Uh oh!

JohnCSimon commented Nov 16, 2019

Uh oh!

JohnCSimon commented Nov 24, 2019

Uh oh!

JohnCSimon commented Nov 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants