Uh oh!
There was an error while loading. Please reload this page.
ci: move most of the prepare config into scripts - #65202
Conversation
rust-highfive
commented
Oct 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Uh oh!
There was an error while loading. Please reload this page.
alexcrichton
commented
Oct 10, 2019
@bors: r+ Thanks for this @pietroalbini! |
bors
commented
Oct 10, 2019
📌 Commit 1591a8e has been approved by |
emilyalbini
commented
Oct 10, 2019
@bors rollup=never At least for linux we're sure it works (the PR builders were fine), but there is a chance I forgot to copy something/typoed stuff for the other platforms, and I don't want this to affect a rollup. |
bors
commented
Oct 13, 2019
⌛ Testing commit 1591a8e with merge f973dbb260d9d091ec71666190125d1df9d1abe6... |
bors
commented
Oct 13, 2019
💔 Test failed - checks-azure |
rust-highfive
commented
Oct 13, 2019
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
commented
Oct 13, 2019
|
Centril
commented
Oct 13, 2019
@bors r- (bors sync goes badly...) |
emilyalbini
commented
Oct 14, 2019
This wasn't actually awscli missing, but the whole prepare step failed to run as it used @bors r=alexcrichton |
bors
commented
Oct 14, 2019
📌 Commit 8d1c3ff has been approved by |
bors
commented
Oct 14, 2019
⌛ Testing commit 8d1c3ff with merge a103c61b9ccbce6c6f65b03d349efbad6c906a35... |
rust-highfive
commented
Oct 14, 2019
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Oct 14, 2019
💔 Test failed - checks-azure |
I mistakenly inverted the "variable is not set" check in bash.
A few dist builders lacked that variable, causing build failures.
d1bd1a6 to
9c44ca2Compareemilyalbini
commented
Oct 25, 2019
@bors try |
bors
commented
Oct 25, 2019
ci: move most of the prepare config into scripts This PR moves most of the configuration from the CI yamls into bash scripts, driven by a small Python script (which understands and emulates the two `##vso[` commands we use). There are two reasons why we'd want to do this: * Being able to prepare the build environment locally by just running `src/ci/prepare.py` simplifies a lot setting up a local VM similar to CI (software pre-installed in the CI images won't be prepared, but it's a start anyway). * When we'll switch to GitHub Actions we'll need to either duplicate code in multiple workflows or write a preprocessor. Having all the prepare steps in a single one is going to simplify the implementation of both options. Along with the move I did a few changes to the actual scripts: * Mirrored all the remaining external URLs we download (except chocolatey) to the `rust-lang-ci-mirrors` bucket, to increase reliability and reduce the chance of supply chain attacks. I didn't audit and mirror the CI scripts outside this PR though. * Extracted CI-specific behavior (like issuing `##vso[` commands and detecting the host platform) into `shared.sh` and included it in most of the scripts. This way a switch to another CI provider will be less painful. It's possible (and easier) to review this commit-by-commit. r? @alexcrichton cc @rust-lang/infra
rust-highfive
commented
Oct 25, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Oct 25, 2019
💔 Test failed - checks-azure |
emilyalbini
commented
Oct 28, 2019
@bors r=alexcrichton p=10 rollup=never |
bors
commented
Oct 28, 2019
📌 Commit c854c44 has been approved by |
bors
commented
Oct 28, 2019
⌛ Testing commit c854c44 with merge a124dd93bef3b80f7934c36172e7f0fae01eca25... |
bors
commented
Oct 28, 2019
💔 Test failed - checks-azure |
rust-highfive
commented
Oct 28, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
emilyalbini
commented
Oct 28, 2019
@bors try |
Uh oh!
There was an error while loading. Please reload this page.
bors
commented
Oct 28, 2019
bors
commented
Oct 28, 2019
☀️ Try build successful - checks-azure |
emilyalbini
commented
Oct 28, 2019
@bors r=alexcrichton p=10 rollup=never |
bors
commented
Oct 28, 2019
📌 Commit 7e05123 has been approved by |
bors
commented
Oct 28, 2019
bors
commented
Oct 28, 2019
☀️ Test successful - checks-azure |
emilyalbini
commented
Oct 28, 2019
Finally 🎉 |
This PR moves most of the configuration from the CI yamls into bash scripts, driven by a small Python script (which understands and emulates the two
##vso[commands we use).There are two reasons why we'd want to do this:
src/ci/prepare.pysimplifies a lot setting up a local VM similar to CI (software pre-installed in the CI images won't be prepared, but it's a start anyway).Along with the move I did a few changes to the actual scripts:
rust-lang-ci-mirrorsbucket, to increase reliability and reduce the chance of supply chain attacks. I didn't audit and mirror the CI scripts outside this PR though.##vso[commands and detecting the host platform) intoshared.shand included it in most of the scripts. This way a switch to another CI provider will be less painful.It's possible (and easier) to review this commit-by-commit.
r? @alexcrichton
cc @rust-lang/infra