Uh oh!
There was an error while loading. Please reload this page.
Revert "Make into schedule drop for the destination" - #65249
Merged
Conversation
This reverts commit 3702683.
rust-highfive
commented
Oct 9, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
nnethercote
commented
Oct 9, 2019
Contributor
@bors r+ |
bors
commented
Oct 9, 2019
Collaborator
📌 Commit a0342c8 has been approved by |
nnethercote
commented
Oct 9, 2019
Contributor
@bors p=1 Because this fixes a drastic perf regression. |
bors
commented
Oct 9, 2019
Collaborator
bors added a commit
that referenced
this pull request
Oct 9, 2019
Revert "Make `into` schedule drop for the destination" This was a *very* large perf regression in some cases. I'll undo the revert once I have time to avoid the regression.
bors
commented
Oct 10, 2019
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a very large perf regression in some cases. I'll undo the revert once I have time to avoid the regression.