Point at associated type for some obligations by estebank · Pull Request #65288 · rust-lang/rust

estebank · 2019-10-10T23:21:23Z

Partially address #57663.

rust-highfive · 2019-10-10T23:21:26Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

cramertj · 2019-10-10T23:51:23Z

I don't think I'm the best reviewer for this, but I'm not sure who is.

estebank · 2019-10-11T01:00:54Z

Maybe @nikomatsakis?

Centril · 2019-10-11T06:46:16Z

@bors try

bors · 2019-10-11T06:46:27Z

⌛ Trying commit cbd994b with merge afb10f4...

Point at associated type for some obligations Partially address #57663.

bors · 2019-10-11T09:45:42Z

☀️ Try build successful - checks-azure
Build commit: afb10f4 (afb10f4c27d428d90c167e912bb259891cd14f5c)

Centril · 2019-10-11T11:55:43Z

@rust-timer build afb10f4

rust-timer · 2019-10-11T11:55:45Z

Queued afb10f4 with parent 000d90b, future comparison URL.

nikomatsakis · 2019-10-11T17:02:46Z

r? @nikomatsakis

rust-timer · 2019-10-12T05:54:53Z

Finished benchmarking try commit afb10f4, comparison URL.

Centril · 2019-10-12T13:59:22Z

Perf looks clean

nikomatsakis

This looks nice @estebank! I have some minor suggestions around refactoring.

estebank · 2019-10-23T15:55:27Z

@nikomatsakis let me know if there are any outstanding changes you'd like me to do.

nikomatsakis · 2019-10-25T20:17:41Z

 let param_env = self.param_env;

+ let item = &self.item;
+ let extend_cause_with_original_assoc_item_obligation = |


Heh. Personally I'd have preferred to see this be a separate method, but I can accept this =) I do like the comments!

nikomatsakis · 2019-10-25T20:18:26Z

@bors r+

bors · 2019-10-25T20:18:27Z

📌 Commit 3a4cacd has been approved by nikomatsakis

bors · 2019-10-26T04:03:08Z

⌛ Testing commit 3a4cacd with merge e39dd255a4db06727866034e3a5288ddbf2b8fc4...

rust-highfive · 2019-10-26T04:06:34Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-26T04:05:26.6882267Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-10-26T04:05:26.6882373Z See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-10-26T04:05:26.6886488Z 2019-10-26T04:05:26.6890979Z Failures
2019-10-26T04:05:26.6897973Z - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-10-26T04:05:26.6898130Z The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-10-26T04:05:27.2648320Z 2019-10-26T04:05:27.2727921Z ##[error]Bash exited with code '1'.
2019-10-26T04:05:27.2941242Z ##[section]Starting: Upload CPU usage statistics
2019-10-26T04:05:27.3050467Z ==============================================================================
2019-10-26T04:05:27.3050558Z Task : Bash
2019-10-26T04:05:27.3050647Z Description : Run a Bash script on macOS, Linux, or Windows
---
2019-10-26T04:05:27.5921823Z ========================== Starting Command Output ===========================
2019-10-26T04:05:27.5928678Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc /d/a/_temp/14d1e8ad-af68-4cae-99bd-2df7273327fa.sh
2019-10-26T04:05:27.6371201Z /d/a/_temp/14d1e8ad-af68-4cae-99bd-2df7273327fa.sh: line 1: aws: command not found
2019-10-26T04:05:27.6403752Z 2019-10-26T04:05:27.6425409Z ##[error]Bash exited with code '127'.
2019-10-26T04:05:27.6504119Z ##[section]Starting: Checkout
2019-10-26T04:05:27.6605334Z ==============================================================================
2019-10-26T04:05:27.6605441Z Task : Get sources
2019-10-26T04:05:27.6605711Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-10-26T04:06:45Z

💔 Test failed - checks-azure

JohnTitor · 2019-10-26T09:39:14Z

It's a network error.
@bors retry

…omatsakis Point at associated type for some obligations Partially address rust-lang#57663.

Point at associated type for some obligations Partially address #57663.

bors · 2019-10-27T03:35:02Z

⌛ Testing commit 3a4cacd with merge cf148a7...

bors · 2019-10-27T07:12:21Z

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing cf148a7 to master...

eddyb · 2019-11-01T15:35:44Z

 body_id: hir::HirId,
 trait_ref: &ty::TraitRef<'tcx>,
 span: Span,
+ item: Option<&'tcx hir::Item>,


I don't think passing around references to the HIR fits ty::wf, this can just be an Option<DefId> and should probably be named something more suggestive.

eddyb · 2019-11-01T15:36:45Z

 let cause = self.cause(traits::MiscObligation);
 let param_env = self.param_env;

+ let item = &self.item;


No need to borrow a Copy field.

rust-highfive assigned cramertj Oct 10, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2019

estebank force-pushed the point-at-assoc-type branch from 447f3ff to c808d66Compare October 10, 2019 23:24

This comment has been minimized.
Sign in to view

estebank force-pushed the point-at-assoc-type branch from c808d66 to 4c3d9faCompare October 11, 2019 01:00

This comment has been minimized.
Sign in to view

bors added a commit that referenced this pull request Oct 11, 2019
Auto merge of#65288- estebank:point-at-assoc-type, r=<try>
afb10f4
Point at associated type for some obligations Partially address #57663.

rust-highfive assigned nikomatsakis and unassigned cramertj Oct 11, 2019

nikomatsakis requested changes Oct 22, 2019
View reviewed changes

Comment threadsrc/test/ui/associated-types/point-at-type-on-obligation-failure-2.stderr Outdated
Comment threadsrc/librustc/ty/wf.rs Outdated
Comment threadsrc/librustc/ty/wf.rs Outdated

estebank force-pushed the point-at-assoc-type branch from cbd994b to 9824ba6Compare October 22, 2019 19:40

estebank added 5 commits October 22, 2019 12:42

Point at associated type for some obligations
58c6591

fix compile-fail test
88e4e2a

Handle projection obligation errors
5b58095

Drive-by formatting
0118278

review comments: move code, fix indentation and change span
669a403

estebank force-pushed the point-at-assoc-type branch from 9824ba6 to 8d4714aCompare October 22, 2019 20:24

Fix rebase
580a93e

estebank force-pushed the point-at-assoc-type branch from 8d4714a to 580a93eCompare October 22, 2019 20:24

Add comments
3a4cacd

estebank force-pushed the point-at-assoc-type branch from 0a7f7b4 to 3a4cacdCompare October 23, 2019 15:54

nikomatsakis approved these changes Oct 25, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019

Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
Rollup merge ofrust-lang#65288- estebank:point-at-assoc-type, r=nik…
677cbd0
…omatsakis Point at associated type for some obligations Partially address rust-lang#57663.

Centril mentioned this pull request Oct 26, 2019
Rollup of 7 pull requests #65854
Closed

bors added a commit that referenced this pull request Oct 27, 2019
Auto merge of#65288- estebank:point-at-assoc-type, r=nikomatsakis
cf148a7
Point at associated type for some obligations Partially address #57663.

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2019

bors merged commit 3a4cacd into rust-lang:masterOct 27, 2019

eddyb reviewed Nov 1, 2019
View reviewed changes

Mark-Simulacrum mentioned this pull request Nov 2, 2019
Compile hangs endlessly in LLVM in await-heavy code when ThinLTO is enabled #66036
Closed

xiaotianrandom mentioned this pull request May 31, 2020
Wrong obligation cause span of associated type mismatch #72806
Closed

estebank deleted the point-at-assoc-type branch November 9, 2023 05:18

Uh oh!

Uh oh!

Conversation

estebank commented Oct 10, 2019

Uh oh!

rust-highfive commented Oct 10, 2019

Uh oh!

This comment has been minimized.

cramertj commented Oct 10, 2019

Uh oh!

estebank commented Oct 11, 2019

Uh oh!

This comment has been minimized.

Centril commented Oct 11, 2019

Uh oh!

bors commented Oct 11, 2019

Uh oh!

bors commented Oct 11, 2019

Uh oh!

Centril commented Oct 11, 2019

Uh oh!

rust-timer commented Oct 11, 2019

Uh oh!

nikomatsakis commented Oct 11, 2019

Uh oh!

rust-timer commented Oct 12, 2019

Uh oh!

Centril commented Oct 12, 2019

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

estebank commented Oct 23, 2019

Uh oh!

nikomatsakisOct 25, 2019

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Oct 25, 2019

Uh oh!

bors commented Oct 25, 2019

Uh oh!

bors commented Oct 26, 2019

Uh oh!

rust-highfive commented Oct 26, 2019

Uh oh!

bors commented Oct 26, 2019

Uh oh!

JohnTitor commented Oct 26, 2019

Uh oh!

bors commented Oct 27, 2019

Uh oh!

bors commented Oct 27, 2019

Uh oh!

eddybNov 1, 2019

Choose a reason for hiding this comment

Uh oh!

eddybNov 1, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants