Skip to content

Remove an outdated test output file - #65415

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:rmtest
Oct 15, 2019
Merged

Remove an outdated test output file#65415
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:rmtest

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

It was accidentally introduced during some rebase, but it's no longer necessary and --bless removes it, but it doesn't fail testing.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2019
@varkor

Copy link
Copy Markdown
Contributor

I thought unused output files were caught. Maybe the .nll ones aren't checked properly.

@bors r+ rollup

@bors

bors commented Oct 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 34bcfca has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
Remove an outdated test output file
It was accidentally introduced during some rebase, but it's no longer necessary and `--bless` removes it, but it doesn't fail testing.
@tmandrytmandry mentioned this pull request Oct 15, 2019
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 10 pull requests
Successful merges:
- #65170 (rustc_metadata: Privatize private code and remove dead code)
- #65260 (Optimize `LexicalResolve::expansion`.)
- #65261 (Remove `Option` from `TokenStream`)
- #65332 (std::fmt: reorder docs)
- #65340 (Several changes to the codegen backend organization)
- #65365 (Include const generic arguments in metadata)
- #65398 (Bring attention to suggestions when the only difference is capitalization)
- #65410 (syntax: add parser recovery for intersection- / and-patterns `p1 @ p2`)
- #65415 (Remove an outdated test output file)
- #65416 (Minor sync changes)
Failed merges:
r? @ghost
@bors
bors merged commit 34bcfca into rust-lang:masterOct 15, 2019
@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

@varkor

Maybe the .nll ones aren't checked properly.

Only some tests have the .nll output and tidy doesn't know whether a certain test have .nll output or not (you need to run the test to determine that), so it just ignores them.

@petrochenkov
petrochenkov deleted the rmtest branch February 22, 2025 18:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@rust-highfive@varkor@bors@nikomatsakis