Skip to content

rustc_codegen_ssa: remove some unnecessary Box special-casing. - #65448

Merged
bors merged 1 commit into
rust-lang:masterfrom
eddyb:codegen-box-less-special
Oct 19, 2019
Merged

rustc_codegen_ssa: remove some unnecessary Box special-casing.#65448
bors merged 1 commit into
rust-lang:masterfrom
eddyb:codegen-box-less-special

Conversation

@eddyb

Copy link
Copy Markdown
Contributor

Could help simplify #60900.

r? @nikomatsakis

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@eddyb

Copy link
Copy Markdown
ContributorAuthor

@bors try (for perf)

@bors

bors commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c39af6e with merge fe00dd0ab564055bb73c11adb998cdabbd8ee569...

@bors

bors commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: fe00dd0ab564055bb73c11adb998cdabbd8ee569 (fe00dd0ab564055bb73c11adb998cdabbd8ee569)

@eddyb

This comment has been minimized.

1 similar comment
@eddyb

Copy link
Copy Markdown
ContributorAuthor

@rust-timer build fe00dd0ab564055bb73c11adb998cdabbd8ee569

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued fe00dd0ab564055bb73c11adb998cdabbd8ee569 with parent 237d54f, future comparison URL.

@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 18, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c39af6e has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…li-obk
rustc_codegen_ssa: remove some unnecessary Box special-casing.
Could help simplify rust-lang#60900.
r? @nikomatsakis
@CentrilCentril mentioned this pull request Oct 19, 2019
bors added a commit that referenced this pull request Oct 19, 2019
Rollup of 5 pull requests
Successful merges:
- #64007 (Add check for overlapping ranges to unreachable patterns lint)
- #65192 (Use structured suggestion for restricting bounds)
- #65226 (BTreeSet symmetric_difference & union optimized)
- #65448 (rustc_codegen_ssa: remove some unnecessary Box special-casing.)
- #65505 (Rc: value -> allocation)
Failed merges:
r? @ghost
@bors
bors merged commit c39af6e into rust-lang:masterOct 19, 2019
@bors

bors commented Oct 19, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #65598) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2019
@eddyb
eddyb deleted the codegen-box-less-special branch October 19, 2019 18:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@eddyb@bors@rust-timer@oli-obk@nikomatsakis@rust-highfive