Suggest borrowing when it would satisfy an unmet trait bound by estebank · Pull Request #65456 · rust-lang/rust

estebank · 2019-10-16T01:43:41Z

When there are multiple implementors for the same trait that is present
in an unmet binding, modify the E0277 error to refer to the parent
obligation and verify whether borrowing the argument being passed in
would satisfy the unmet bound. If it would, suggest it.

Fix#56368.

rust-highfive · 2019-10-16T01:43:45Z

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2019-10-16T01:44:34Z

This is the particular common case (std::str::pattern::Pattern) that is encountered often by newcomers and this PR is meant to solve.

estebank · 2019-10-16T01:45:42Z

Stable:

This PR:

estebank · 2019-10-31T20:47:44Z

CC @Centril in case you're interested in this.

Centril · 2019-10-31T21:17:47Z

.stderr diffs look good but the code is alien to me :)

estebank · 2019-11-07T18:43:05Z

ping @matthewjasper

matthewjasper · 2019-11-07T19:05:56Z

@bors r+

bors · 2019-11-07T19:05:57Z

📌 Commit 001295beefad4b250b2d940fc1e023d1894bad18 has been approved by matthewjasper

estebank · 2019-11-14T21:40:55Z

@bors r=matthewjasper

bors · 2019-11-14T21:40:56Z

📌 Commit 85d7ff6 has been approved by matthewjasper

estebank · 2019-11-16T04:52:15Z

@bors r=matthewjasper

bors · 2019-11-16T04:52:16Z

📌 Commit e5e3c52e9e6561ff33184b4fe17adc2dbc071fe4 has been approved by matthewjasper

bors · 2019-11-16T05:46:12Z

☔ The latest upstream changes (presumably #66453) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2019-11-16T06:04:16Z

@bors r-

When there are multiple implementors for the same trait that is present in an unmet binding, modify the E0277 error to refer to the parent obligation and verify whether borrowing the argument being passed in would satisfy the unmet bound. If it would, suggest it.

estebank · 2019-11-17T19:24:26Z

@bors r=matthewjasper

bors · 2019-11-17T19:24:27Z

📌 Commit 2fe8371 has been approved by matthewjasper

bors · 2019-11-18T00:05:45Z

⌛ Testing commit 2fe8371 with merge 361791b...

Suggest borrowing when it would satisfy an unmet trait bound When there are multiple implementors for the same trait that is present in an unmet binding, modify the E0277 error to refer to the parent obligation and verify whether borrowing the argument being passed in would satisfy the unmet bound. If it would, suggest it. Fix#56368.

bors · 2019-11-18T03:06:34Z

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing 361791b to master...

rust-highfive · 2019-11-18T03:07:50Z

📣 Toolstate changed by #65456!

Tested on commit 361791b.
Direct link to PR: #65456

🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

@amanjeev

Tested on commit rust-lang/rust@361791b. Direct link to PR: <rust-lang/rust#65456> 🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

rust-highfive assigned matthewjasper Oct 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2019

estebank commented Oct 16, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

estebank mentioned this pull request Oct 17, 2019
add IntoFuture trait and support for await #65244
Merged

This comment has been minimized.
Sign in to view

estebank force-pushed the trait-bound-borrow branch from 99bf5dc to dc00b1aCompare October 23, 2019 23:23

This comment has been minimized.
Sign in to view

bjorn3 reviewed Oct 26, 2019
View reviewed changes

Comment threadsrc/test/ui/traits/traits-negative-impls.rs Outdated

estebank force-pushed the trait-bound-borrow branch from dc00b1a to 6f0731eCompare October 27, 2019 20:42

matthewjasper reviewed Nov 3, 2019
View reviewed changes

Comment threadsrc/librustc/traits/error_reporting.rs Outdated
Comment threadsrc/librustc/traits/error_reporting.rs Outdated

This comment has been minimized.
Sign in to view

estebank force-pushed the trait-bound-borrow branch from 6f0731e to 001295bCompare November 6, 2019 18:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2019

estebank force-pushed the trait-bound-borrow branch 2 times, most recently from 8970e3a to 85d7ff6Compare November 9, 2019 02:24

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 14, 2019

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2019

estebank force-pushed the trait-bound-borrow branch from 85d7ff6 to e5e3c52Compare November 16, 2019 02:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2019

estebank added 5 commits November 16, 2019 13:23

Tweak code formatting
405a3dd

Modify primary label message to be inline with error message
970503b

Remove unnecessary note
0f7f234

Account for rustc_on_unimplemented
7a2f3ee

estebank force-pushed the trait-bound-borrow branch from e5e3c52 to 5c5cbc0Compare November 16, 2019 21:51

This comment has been minimized.
Sign in to view

review comments and fix rebase
2fe8371

estebank force-pushed the trait-bound-borrow branch from 5c5cbc0 to 2fe8371Compare November 17, 2019 00:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 18, 2019

bors merged commit 2fe8371 into rust-lang:masterNov 18, 2019

Uh oh!

Uh oh!

Conversation

estebank commented Oct 16, 2019

Uh oh!

rust-highfive commented Oct 16, 2019

Uh oh!

estebankOct 16, 2019

Choose a reason for hiding this comment

Uh oh!

estebank commented Oct 16, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

estebank commented Oct 31, 2019

Uh oh!

Centril commented Oct 31, 2019

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

estebank commented Nov 7, 2019

Uh oh!

matthewjasper commented Nov 7, 2019

Uh oh!

bors commented Nov 7, 2019

Uh oh!

This comment has been minimized.

estebank commented Nov 14, 2019

Uh oh!

bors commented Nov 14, 2019

Uh oh!

estebank commented Nov 16, 2019

Uh oh!

bors commented Nov 16, 2019

Uh oh!

bors commented Nov 16, 2019

Uh oh!

estebank commented Nov 16, 2019

Uh oh!

This comment has been minimized.

estebank commented Nov 17, 2019

Uh oh!

bors commented Nov 17, 2019

Uh oh!

bors commented Nov 18, 2019

Uh oh!

bors commented Nov 18, 2019

Uh oh!

rust-highfive commented Nov 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estebank commented Oct 16, 2019•
edited
Loading