Skip to content

Deprecated proc_macro doesn't trigger warning on build library - #65484

Closed
XiangQingW wants to merge 0 commit into
rust-lang:masterfrom
XiangQingW:proc_macro
Closed

Deprecated proc_macro doesn't trigger warning on build library#65484
XiangQingW wants to merge 0 commit into
rust-lang:masterfrom
XiangQingW:proc_macro

Conversation

@XiangQingW

@XiangQingWXiangQingW commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2019
@XiangQingWXiangQingW mentioned this pull request Oct 17, 2019
Merged
petrochenkov
petrochenkov reviewed Oct 17, 2019
View reviewed changes
Comment threadsrc/libsyntax/ext/build.rs Outdated

@petrochenkovpetrochenkovOct 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libsyntax/ext/build.rs is kind of deprecated, so it's better to avoid extending it, but rather use attr::mk_nested_word_item and attr::mk_list_item directly in the proc macro harness.

@XiangQingWXiangQingWOct 17, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'd love to change it.

@petrochenkov

petrochenkov commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

This needs a test.
To test this you can copy test/ui/proc-macro/auxiliary/attributes-on-definitions.rs into test/ui/proc-macro and remove unnecessary parts.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
@bors

bors commented Oct 17, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #65495) made this pull request unmergeable. Please resolve the merge conflicts.

@joelpalmer

joelpalmer commented Oct 21, 2019

Copy link
Copy Markdown

Ping from Triage: Hi @XiangQingW, any updates?

@XiangQingW

XiangQingW commented Oct 21, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ping from Triage: Hi @XiangQingW, any updates?

Yes, I'm working on this. I mess up with conflict and create a new pr ##65666.

@petrochenkovpetrochenkov mentioned this pull request Oct 24, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deprecated proc_macro trigger warning on build library

5 participants

@XiangQingW@rust-highfive@petrochenkov@bors@joelpalmer