Skip to content

Improve error message for APIT with explicit generic arguments - #65614

Merged
bors merged 1 commit into
rust-lang:masterfrom
varkor:apit-explicit-generics
Oct 21, 2019
Merged

Improve error message for APIT with explicit generic arguments#65614
bors merged 1 commit into
rust-lang:masterfrom
varkor:apit-explicit-generics

Conversation

@varkor

Copy link
Copy Markdown
Contributor

This is disallowed with type or const generics. cc #61410.

@varkorvarkor added the F-const_generics `#![feature(const_generics)]` label Oct 20, 2019
@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2019
@varkorvarkor changed the title Improve error message for APIT with explicit generic parametersImprove error message for APIT with explicit generic argumentsOct 20, 2019
@varkor
varkorforce-pushed the apit-explicit-generics branch from 8016331 to 547259fCompareOctober 20, 2019 00:22
Comment threadsrc/test/ui/synthetic-param.stderr Outdated

@varkorvarkorOct 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This span is not very good. I'll file a follow up issue.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #65642.

This is disallowed with type or const generics.
@varkor
varkorforce-pushed the apit-explicit-generics branch from 547259f to 2f7c9a2CompareOctober 20, 2019 00:40
@matthewjasper

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 20, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 2f7c9a2 has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 20, 2019
…tthewjasper
Improve error message for APIT with explicit generic arguments
This is disallowed with type or const generics. cc rust-lang#61410.
@CentrilCentril mentioned this pull request Oct 20, 2019
bors added a commit that referenced this pull request Oct 20, 2019
Rollup of 8 pull requests
Successful merges:
- #65314 (rustdoc: forward -Z options to rustc)
- #65592 (clarify const_prop ICE protection comment)
- #65603 (Avoid ICE when include! is used by stdin crate)
- #65614 (Improve error message for APIT with explicit generic arguments)
- #65629 (Remove `borrowck_graphviz_postflow` from test)
- #65633 (Remove leading :: from paths in doc examples)
- #65638 (Rename the default argument 'def' to 'default')
- #65639 (Fix parameter name in documentation)
Failed merges:
r? @ghost
@bors
bors merged commit 2f7c9a2 into rust-lang:masterOct 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-const_generics`#![feature(const_generics)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@varkor@rust-highfive@matthewjasper@bors