Uh oh!
There was an error while loading. Please reload this page.
Forbid non-structural_match types in const generics - #65627
Merged
bors merged 7 commits intoOct 25, 2019
Conversation
rust-highfive
commented
Oct 20, 2019
Contributor
Some changes occurred in diagnostic error codes |
rust-highfive
commented
Oct 20, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Oct 20, 2019
Contributor
IIRC, resolve had some hack making sure that generic parameters cannot be used in const generics. |
This comment has been minimized.
This comment has been minimized.
varkor
commented
Oct 20, 2019
ContributorAuthor
@petrochenkov: just remembered this too — working on that now. |
Centril
commented
Oct 20, 2019
Contributor
Shouldn't this use the mechanism in #65519? |
Centril
commented
Oct 20, 2019
Contributor
(cc @pnkfelix) |
This comment has been minimized.
This comment has been minimized.
varkor
commented
Oct 20, 2019
ContributorAuthor
@Centril: this is compatible with that PR (up to rebasing). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
varkorforce-pushed
the
const-generics-forbid-non-structural_match
branch
2 times, most recently
from
October 21, 2019 09:17
9e66c91 to
ee55bccCompare
This comment has been minimized.
This comment has been minimized.
varkorforce-pushed
the
const-generics-forbid-non-structural_match
branch
from
October 21, 2019 15:54
ee55bcc to
161fab9Comparevarkor
commented
Oct 21, 2019
ContributorAuthor
@petrochenkov: I've removed the hack from resolve. |
This comment has been minimized.
This comment has been minimized.
varkorforce-pushed
the
const-generics-forbid-non-structural_match
branch
from
October 22, 2019 11:28
54eac6a to
2dda8adComparepetrochenkov
commented
Oct 22, 2019
Contributor
@bors r+ |
bors
commented
Oct 22, 2019
Collaborator
📌 Commit 2dda8ad has been approved by |
bors
commented
Oct 22, 2019
Collaborator
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
varkor
commented
Oct 23, 2019
ContributorAuthor
@bors rollup |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 24, 2019
…ructural_match, r=petrochenkov Forbid non-`structural_match` types in const generics Fixesrust-lang#60286.
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 24, 2019
…ructural_match, r=petrochenkov Forbid non-`structural_match` types in const generics Fixesrust-lang#60286.
bors added a commit
that referenced
this pull request
Oct 25, 2019
Rollup of 8 pull requests Successful merges: - #65625 (Turn crate store into a resolver output) - #65627 (Forbid non-`structural_match` types in const generics) - #65710 (Update cargo) - #65729 (Update test cases for vxWorks) - #65746 (Tweak format string error to point at arguments always) - #65753 (Don't assert for different instance on impl trait alias) - #65755 (Avoid ICE when adjusting bad self ty) - #65766 (Update hashbrown to 0.6.2) Failed merges: r? @ghost
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#60286.