Uh oh!
There was an error while loading. Please reload this page.
Fix unresolved type span inside async object - #65668
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebank
commented
Oct 21, 2019
Does this change have a user visible change? |
@estebank error[E0698]: type inside `async` object must be known in this context
--> src/lib.rs:23:25
|
23 | let server = server.serve(hyper::service::make_service_fn(move |_| {
| ^^^^^ cannot infer type for `ME`
|
note: the type is part of the `async` object because of this `await`
--> src/lib.rs:34:5
|
34 | server.await
| ^^^^^^^^^^^^To: error[E0698]: type inside `async fn` body must be known in this context
--> src/lib.rs:15:13
|
15 | Ok(hyper::service::service_fn(move |req| {
| ^^ cannot infer type for `ME`
|
note: the type is part of the `async fn` body because of this `await`
--> src/lib.rs:24:5
|
24 | server.await
| ^^^^^^^^^^^^
error: aborting due to previous errorbut I should figure out a test/ui. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
estebank
commented
Oct 22, 2019
r=me with a test |
nikomatsakis
commented
Oct 25, 2019
Looks good to me, too |
JohnCSimon
commented
Nov 2, 2019
Ping from triage. |
estebank
commented
Nov 3, 2019
@csmoe can you add a ui test exercising this new code? |
csmoe
commented
Nov 5, 2019
@estebank it's a bit complicated, still trying. |
JohnCSimon
commented
Nov 9, 2019
bors
commented
Nov 11, 2019
☔ The latest upstream changes (presumably #66252) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
commented
Nov 16, 2019
JohnCSimon
commented
Nov 24, 2019
Pinging once again from triage: Thank you. |
JohnCSimon
commented
Nov 29, 2019
Triage: @csmoe - unfortunately this PR has sat idle for several weeks, I'm marking this as inactive. Please reopen this PR when you're ready to move forward. |
Fix unresolved type span inside async object Closesrust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Fix unresolved type span inside async object Closesrust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Fix unresolved type span inside async object Closesrust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Closes#65180
r? @estebank
cc @nikomatsakis@cramertj