Skip to content

Update clippy - #65713

Merged
bors merged 4 commits into
rust-lang:masterfrom
tesuji:clippy-up
Oct 23, 2019
Merged

Update clippy#65713
bors merged 4 commits into
rust-lang:masterfrom
tesuji:clippy-up

Conversation

@tesuji

@tesujitesuji commented Oct 23, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Replaces #65690
cc #65503
Closes#65683

@rust-highfive

rust-highfive commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2019
@tesuji

tesuji commented Oct 23, 2019

Copy link
Copy Markdown
ContributorAuthor

cc @flip1995 , @oli-obk, @Centril
r? @Manishearth

@tesujitesuji mentioned this pull request Oct 23, 2019
Closed
@Manishearth

Manishearth commented Oct 23, 2019

Copy link
Copy Markdown
Member

@bors r+ p=2

@bors

bors commented Oct 23, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 557cbd0 has been approved by Manishearth

@bors

bors commented Oct 23, 2019

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2019
@bors

bors commented Oct 23, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 557cbd0 with merge d6e4028...

bors added a commit that referenced this pull request Oct 23, 2019
@bors
Auto merge of#65713- lzutao:clippy-up, r=Manishearth
d6e4028
Update clippy
Replaces #65690
cc #65503Closes#65683
@bors

bors commented Oct 23, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Manishearth
Pushing d6e4028 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2019
@bors
bors merged commit 557cbd0 into rust-lang:masterOct 23, 2019
@rust-highfive

rust-highfive commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #65713!

Tested on commit d6e4028.
Direct link to PR: #65713

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 23, 2019
@rust-highfive
📣 Toolstate changed byrust-lang/rust#65713!
8bf3aa0
Tested on commit rust-lang/rust@d6e4028.
Direct link to PR: <rust-lang/rust#65713>
🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).
@borsbors mentioned this pull request Oct 23, 2019
Merged
@tesuji
tesuji deleted the clippy-up branch October 23, 2019 10:13
@RalfJung

RalfJung commented Oct 24, 2019

Copy link
Copy Markdown
Member

Does this make enough types from libtest public again to fix Manishearth/compiletest-rs#197 ?

@RalfJungRalfJung mentioned this pull request Oct 24, 2019
Closed
@tesuji

tesuji commented Oct 24, 2019

Copy link
Copy Markdown
ContributorAuthor

yes, at least for compiletest_rs v0.3.25.

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Nov 2, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ManishearthManishearth

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#65671

7 participants

@tesuji@rust-highfive@Manishearth@bors@RalfJung@eddyb@flip1995