Uh oh!
There was an error while loading. Please reload this page.
Fix default "disable-shortcuts" feature value - #65740
Merged
bors merged 1 commit intoOct 25, 2019
Merged
Conversation
kinnison
approved these changes
Oct 24, 2019
kinnison
left a comment
Contributor
There was a problem hiding this comment.
Well this is clean and clear. 👍
GuillaumeGomez
commented
Oct 24, 2019
MemberAuthor
Considering it's changing the default doc behavior, I'd like to get this merged as soon as possible. @bors: r=kinnison p=1 |
bors
commented
Oct 24, 2019
Collaborator
📌 Commit 01a1bcb has been approved by |
GuillaumeGomez
commented
Oct 24, 2019
MemberAuthor
@Mark-Simulacrum This PR will need to be backported to beta. |
Mark-Simulacrum
commented
Oct 24, 2019
Member
This line is not on beta? So I suspect this can't be backported to beta... In any case, the process is to beta-nominate and get the rustdoc team to approve the beta backport. |
Dylan-DPC-zz
commented
Oct 24, 2019
@bors r+ rollup |
bors
commented
Oct 24, 2019
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Oct 24, 2019
Collaborator
📌 Commit 01a1bcb has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 25, 2019
…-feature, r=Dylan-DPC Fix default "disable-shortcuts" feature value Follow-up of rust-lang#65656 It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!). r? @Dylan-DPC cc @kinnison
GuillaumeGomez
commented
Oct 25, 2019
MemberAuthor
@Mark-Simulacrum If the previous PR for this change isn't in beta, then it's fine. 😌 |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 25, 2019
…-feature, r=Dylan-DPC Fix default "disable-shortcuts" feature value Follow-up of rust-lang#65656 It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!). r? @Dylan-DPC cc @kinnison
bors added a commit
that referenced
this pull request
Oct 25, 2019
Rollup of 9 pull requests Successful merges: - #64639 (Stabilize `#[non_exhaustive]` (RFC 2008)) - #65074 (Fix the start/end byte positions in the compiler JSON output) - #65315 (Intern place projection) - #65685 (Fix check of `statx` and handle EPERM) - #65731 (Prevent unnecessary allocation in PathBuf::set_extension.) - #65740 (Fix default "disable-shortcuts" feature value) - #65787 (move panictry! to where it is used.) - #65789 (move Attribute::with_desugared_doc to librustdoc) - #65790 (move report_invalid_macro_expansion_item to item.rs) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #65656
It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!).
r? @Dylan-DPC
cc @kinnison