Skip to content

Use structured suggestions for missing associated items - #65752

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:sugg
Nov 7, 2019
Merged

Use structured suggestions for missing associated items#65752
bors merged 2 commits into
rust-lang:masterfrom
estebank:sugg

Conversation

@estebank

@estebankestebank commented Oct 24, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

When encountering an impl that is missing associated items required by its trait, use structured suggestions at an appropriate place in the impl.

@rust-highfive

rust-highfive commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2019
@estebank

estebank commented Oct 24, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @Centril

Looking at the changes one commit at a time will be easier to follow.

@rust-highfiverust-highfive assigned Centril and unassigned eddybOct 24, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Oct 24, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just some initial feedback; I'll look more in-depth later.

Comment threadsrc/librustc/ty/mod.rs Outdated
Comment threadsrc/librustc/ty/sty.rs Outdated
Comment threadsrc/librustc/ty/mod.rs Outdated
Comment threadsrc/librustc/ty/mod.rs Outdated
@Centril

This comment has been minimized.

Sign in to view
@estebank
estebankforce-pushed the sugg branch 2 times, most recently from f73eb2c to ab187baCompareOctober 24, 2019 22:36
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@CentrilCentril added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
@CentrilCentril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 28, 2019
Centril
Centril reviewed Oct 29, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/expr.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2019
@estebankestebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2019
Centril
Centril reviewed Oct 31, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
@Centril

Centril commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

r=me with two remaining nits addressed.

@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2019
@bors

This comment has been minimized.

Sign in to view
@estebank

estebank commented Nov 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Nov 6, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit a12a32a has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2019
@bors

bors commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a12a32a with merge 67e714a18f52bd750356eb37155ed35134022025...

Centril added a commit to Centril/rust that referenced this pull request Nov 7, 2019
@Centril
Rollup merge ofrust-lang#65752- estebank:sugg, r=Centril
a3c8572
Use structured suggestions for missing associated items
When encountering an `impl` that is missing associated items required by its `trait`, use structured suggestions at an appropriate place in the `impl`.
@CentrilCentril mentioned this pull request Nov 7, 2019
Merged
@Centril

Centril commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

@bors retry rolled up.

bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of#66180- Centril:rollup-c1ji943, r=Centril
50f8aad
Rollup of 5 pull requests
Successful merges:
- #59789 (Revert two unapproved changes to rustc_typeck.)
- #65752 (Use structured suggestions for missing associated items)
- #65884 (syntax: ABI-oblivious grammar)
- #65974 (A scheme for more macro-matcher friendly pre-expansion gating)
- #66017 (Add future incompatibility lint for `array.into_iter()`)
Failed merges:
- #66056 (rustc_metadata: Some reorganization of the module structure)
r? @ghost
@bors
bors merged commit a12a32a into rust-lang:masterNov 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@estebank@rust-highfive@Centril@bors@eddyb