Skip to content

Move help popup generation code - #65780

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:move-help-popup-generation-code
Nov 4, 2019
Merged

Move help popup generation code#65780
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:move-help-popup-generation-code

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Oct 24, 2019

Copy link
Copy Markdown
Member

The first commit is just a small cleanup.

The idea behind this PR is to reduce a bit more the generated HTML files by moving the duplicated code into one place instead.

r? @kinnison

@GuillaumeGomez
GuillaumeGomezforce-pushed the move-help-popup-generation-code branch from 1dcc915 to 7c46ed2CompareOctober 24, 2019 22:37
kinnison
kinnison approved these changes Oct 25, 2019
View reviewed changes

@kinnisonkinnison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My JavaScript-fu isn't massively strong, but afaict that looks okay. Assuming you've confirmed that it works as expected, 👍 from me.

@GuillaumeGomez

GuillaumeGomez commented Oct 25, 2019

Copy link
Copy Markdown
MemberAuthor

Let's ask someone else to review it as well then!

r? @QuietMisdreavus

@JohnCSimonJohnCSimon added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2019
@bors

bors commented Oct 26, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #65845) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez
GuillaumeGomezforce-pushed the move-help-popup-generation-code branch from 7c46ed2 to 91ef960CompareOctober 27, 2019 10:42
@JohnCSimon

JohnCSimon commented Nov 2, 2019

Copy link
Copy Markdown

Ping from triage
@QuietMisdreavus can you please review this PR?
cc: @GuillaumeGomez
Thanks

@GuillaumeGomez

GuillaumeGomez commented Nov 2, 2019

Copy link
Copy Markdown
MemberAuthor

r? @Mark-Simulacrum

@Mark-Simulacrum

Mark-Simulacrum commented Nov 2, 2019

Copy link
Copy Markdown
Member

I guess keyboard shortcuts don't work without JS anyway, right? So this isn't losing functionality (or documentation of that functionality)?

@GuillaumeGomez

GuillaumeGomez commented Nov 2, 2019

Copy link
Copy Markdown
MemberAuthor

Nope, just reducing generated HTML size and making page load faster for JS-disabled people (which is a complete side-effect, but a nice one I think? haha).

@Mark-Simulacrum

Mark-Simulacrum commented Nov 3, 2019

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 3, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 91ef960 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2019
@bors

bors commented Nov 3, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 91ef960 with merge 0d5264a...

bors added a commit that referenced this pull request Nov 3, 2019
@bors
Auto merge of#65780- GuillaumeGomez:move-help-popup-generation-code…
0d5264a
…, r=Mark-Simulacrum
Move help popup generation code
The first commit is just a small cleanup.
The idea behind this PR is to reduce a bit more the generated HTML files by moving the duplicated code into one place instead.
r? @kinnison
@bors

bors commented Nov 4, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 0d5264a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2019
@bors
bors merged commit 91ef960 into rust-lang:masterNov 4, 2019
@GuillaumeGomez
GuillaumeGomez deleted the move-help-popup-generation-code branch November 4, 2019 09:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kinnisonkinnisonkinnison approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@bors@JohnCSimon@Mark-Simulacrum@kinnison@QuietMisdreavus