gate rustc_on_unimplemented under rustc_attrs by Centril · Pull Request #65794 · rust-lang/rust

Centril · 2019-10-25T05:41:36Z

Move rustc_on_implemented from the on_implemented gate to rustc_attrs as it is internal.

varkor · 2019-10-25T23:00:04Z

We should remove the feature gate too: otherwise it's possible to enable the feature without any effect.

Centril · 2019-10-26T06:39:20Z

@varkor I don't know what you mean by "without any effect". The only technical change is the omission of the tracking issue. Would you prefer to move it to rustc_attrs?

varkor · 2019-10-26T09:21:20Z

I mean that you can currently write:

#![feature(on_unimplemented)]

And there won't be any error, which there ought to be after this change.

Centril · 2019-10-26T10:24:43Z

@varkor I didn't intend for that to be an error, only to remove any mention of the tracking issue. The attribute has to be gated by something, either the existing feature gate name or rustc_attrs. Do we want to gate all internal features with rustc_attrs? The current practice seems to be all over the place.

varkor · 2019-10-26T11:18:30Z

What other rustc_* attributes use their own feature gate rather than rustc_attrs?

Centril · 2019-10-26T13:52:59Z

Seems like it's a small minority:

rustc_const_unstable
rustc_diagnostic_item
rustc_paren_sugar

(rustc_ attributes are not the only internal attributes)

varkor · 2019-10-26T16:06:26Z

Do you know if there's any particular reason for those? I'll investigate later if not. I would have thought that all rustc_* attributes could come under the same feature gate. (It's reasonable for other internal attributes to have different feature gates.)

Centril · 2019-10-26T16:08:54Z

Do you know if there's any particular reason for those?

No idea but my guess is that it would be happenstance.

varkor · 2019-10-26T16:32:40Z

As far as I can tell, rustc_paren_sugar and rustc_const_unstable should be gated on rustc_attrs. rustc_diagnostic_item already is gated on rustc_attrs.

So I think we should gate rustc_on_unimplemented on rustc_attrs too (and change the others either here, or in a follow up).

Centril · 2019-10-27T16:35:48Z

@varkor Moved rustc_on_unimplemented for now. :)

Centril · 2019-10-28T20:37:06Z

@varkor I think it's good to go now.

varkor · 2019-11-02T15:46:55Z

r=me with typo fixed.

Centril · 2019-11-06T06:35:33Z

Typo fixed; @bors r=varkor rollup

bors · 2019-11-06T06:35:34Z

📌 Commit 1c7595f has been approved by varkor

@varkor

gate rustc_on_unimplemented under rustc_attrs Move `rustc_on_implemented` from the `on_implemented` gate to `rustc_attrs` as it is internal. Closesrust-lang#29628 r? @varkor

@varkor

gate rustc_on_unimplemented under rustc_attrs Move `rustc_on_implemented` from the `on_implemented` gate to `rustc_attrs` as it is internal. Closesrust-lang#29628 r? @varkor

@varkor

gate rustc_on_unimplemented under rustc_attrs Move `rustc_on_implemented` from the `on_implemented` gate to `rustc_attrs` as it is internal. Closesrust-lang#29628 r? @varkor

@ghost

Rollup of 12 pull requests Successful merges: - #65794 (gate rustc_on_unimplemented under rustc_attrs) - #65945 (Optimize long-linker-command-line test) - #66044 (Improve uninit/zeroed lint) - #66076 (HIR docs: mention how to resolve method paths) - #66084 (Do not require extra LLVM backends for `x.py test` to pass) - #66111 (improve from_raw_parts docs) - #66114 (Improve std::thread::Result documentation) - #66117 (Fixed PhantomData markers in Arc and Rc) - #66146 (Remove unused parameters in `__thread_local_inner`) - #66147 (Miri: Refactor to_scalar_ptr out of existence) - #66162 (Fix broken link in README) - #66171 (Update link on CONTRIBUTING.md) Failed merges: r? @ghost

rust-highfive assigned varkor Oct 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2019

Centril changed the title ~~on_unimplemented is internal and doesn't need a feature gate.~~on_unimplemented is internal and doesn't need a tracking issue.Oct 25, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019

Centril force-pushed the unimpl-internal branch from d161047 to d3d7bf3Compare October 27, 2019 16:34

Centril changed the title ~~on_unimplemented is internal and doesn't need a tracking issue.~~gate rustc_on_unimplemented under rustc_attrsOct 27, 2019

Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2019

This comment has been minimized.
Sign in to view

Centril force-pushed the unimpl-internal branch from d3d7bf3 to 0e817dbCompare October 27, 2019 18:54

This comment has been minimized.
Sign in to view

Centril mentioned this pull request Oct 27, 2019
Explain rustc_on_unimplementedrust-lang/rustc-dev-guide#484
Merged

Centril force-pushed the unimpl-internal branch from 0e817db to d32b9b4Compare October 27, 2019 19:30

This comment has been minimized.
Sign in to view

Centril force-pushed the unimpl-internal branch from d32b9b4 to 2f3bf53Compare October 28, 2019 03:49

This comment has been minimized.
Sign in to view

varkor reviewed Nov 2, 2019
View reviewed changes

Comment threadsrc/libsyntax/feature_gate/builtin_attrs.rs Outdated

varkor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2019

gate rustc_on_unimplemented under rustc_attrs
1c7595f

Centril force-pushed the unimpl-internal branch from 2f3bf53 to 1c7595fCompare November 6, 2019 06:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2019

emilyalbini mentioned this pull request Nov 6, 2019
Rollup of 8 pull requests #66160
Closed

JohnTitor mentioned this pull request Nov 6, 2019
Rollup of 11 pull requests #66169
Closed

JohnTitor mentioned this pull request Nov 7, 2019
Rollup of 12 pull requests #66175
Merged

bors merged commit 1c7595f into rust-lang:masterNov 7, 2019

Centril deleted the unimpl-internal branch November 7, 2019 07:19

Centril mentioned this pull request Nov 7, 2019
Stage0 step #66156
Merged

Uh oh!

Uh oh!

Conversation

Centril commented Oct 25, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varkor commented Oct 25, 2019

Uh oh!

Centril commented Oct 26, 2019

Uh oh!

varkor commented Oct 26, 2019

Uh oh!

Centril commented Oct 26, 2019

Uh oh!

varkor commented Oct 26, 2019

Uh oh!

Centril commented Oct 26, 2019

Uh oh!

varkor commented Oct 26, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centril commented Oct 26, 2019

Uh oh!

varkor commented Oct 26, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centril commented Oct 27, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Centril commented Oct 28, 2019

Uh oh!

This comment has been minimized.

Uh oh!

varkor commented Nov 2, 2019

Uh oh!

Centril commented Nov 6, 2019

Uh oh!

bors commented Nov 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Centril commented Oct 25, 2019•
edited
Loading

varkor commented Oct 26, 2019•
edited
Loading

varkor commented Oct 26, 2019•
edited
Loading