Skip to content

librustc_lexer: Enhance documentation - #65849

Merged
bors merged 1 commit into
rust-lang:masterfrom
popzxc:document-librustc_lexer
Oct 28, 2019
Merged

librustc_lexer: Enhance documentation#65849
bors merged 1 commit into
rust-lang:masterfrom
popzxc:document-librustc_lexer

Conversation

@popzxc

@popzxcpopzxc commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

This PR enhances documentation state of the librustc_lexer (as initiative caused by rustc-guide#474), by adding:

  • Module documentation.
  • Doc-comments (and a bit of usual comments) in non-obvious (as for me) places.

r? @petrochenkov

cc @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2019
@Centril

Centril commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

cc @matklad

matklad
matklad reviewed Oct 26, 2019
View reviewed changes
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/unescape.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
petrochenkov
petrochenkov reviewed Oct 27, 2019
View reviewed changes
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
Comment threadsrc/librustc_lexer/src/lib.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2019
@popzxc
librustc_lexer: Enhance documentation
993b920
Apply review suggestions
Apply review suggestions
@petrochenkov

petrochenkov commented Oct 27, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 993b920 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 27, 2019
@Centril
Rollup merge ofrust-lang#65849- popzxc:document-librustc_lexer, r=p…
2cee7ba
…etrochenkov
librustc_lexer: Enhance documentation
This PR enhances documentation state of the `librustc_lexer` (as initiative caused by [rustc-guide#474](rust-lang/rustc-dev-guide#474)), by adding:
- Module documentation.
- Doc-comments (and a bit of usual comments) in non-obvious (as for me) places.
r? @petrochenkov
cc @Centril
@CentrilCentril mentioned this pull request Oct 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 28, 2019
@Centril
Rollup merge ofrust-lang#65849- popzxc:document-librustc_lexer, r=p…
575058f
…etrochenkov
librustc_lexer: Enhance documentation
This PR enhances documentation state of the `librustc_lexer` (as initiative caused by [rustc-guide#474](rust-lang/rustc-dev-guide#474)), by adding:
- Module documentation.
- Doc-comments (and a bit of usual comments) in non-obvious (as for me) places.
r? @petrochenkov
cc @Centril
@CentrilCentril mentioned this pull request Oct 28, 2019
Merged
bors added a commit that referenced this pull request Oct 28, 2019
@bors
Auto merge of#65885- Centril:rollup-y6b2qbf, r=Centril
9285d40
Rollup of 6 pull requests
Successful merges:
- #64747 (Stabilize `Option::flatten`)
- #65664 (`std::panic::Location` is a lang_item, add `core::intrinsics::caller_location` (RFC 2091 3/N))
- #65792 (rustc, rustc_passes: reduce deps on rustc_expand)
- #65849 (librustc_lexer: Enhance documentation)
- #65873 (doc: explain why it is unsafe to construct Vec<u8> from Vec<u16>)
- #65880 (Gather together usefulness tests)
Failed merges:
r? @ghost
@bors
bors merged commit 993b920 into rust-lang:masterOct 28, 2019
@popzxc
popzxc deleted the document-librustc_lexer branch October 28, 2019 07:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments
+2 more reviewers
@CentrilCentrilCentril left review comments
@matkladmatkladmatklad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@popzxc@Centril@petrochenkov@bors@matklad@rust-highfive