Skip to content

Make ItemContext available for better diagnositcs - #65902

Merged
bors merged 1 commit into
rust-lang:masterfrom
gilescope:issue62570
Nov 1, 2019
Merged

Make ItemContext available for better diagnositcs#65902
bors merged 1 commit into
rust-lang:masterfrom
gilescope:issue62570

Conversation

@gilescope

@gilescopegilescope commented Oct 28, 2019•
edited by estebank
Loading

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2019
@gilescopegilescope changed the title WIP: Make ItemContext available for better diagnositcs.WIP: Make ItemContext available for better diagnositcs. Fixes #62570Oct 28, 2019
@gilescope

gilescope commented Oct 28, 2019

Copy link
Copy Markdown
ContributorAuthor

Fixes #62570

@Centril

Centril commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

r? @estebank

estebank
estebank reviewed Oct 28, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
estebank
estebank reviewed Oct 28, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
estebank
estebank reviewed Oct 28, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
estebank
estebank reviewed Oct 28, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
estebank
estebank reviewed Oct 28, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
@rust-highfive

This comment has been minimized.

Sign in to view
estebank
estebank reviewed Oct 29, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
@gilescope
gilescopeforce-pushed the issue62570 branch 2 times, most recently from 803f1da to 8c5f0f6CompareOctober 30, 2019 00:07
estebank
estebank reviewed Oct 30, 2019
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated
@gilescopegilescope changed the title WIP: Make ItemContext available for better diagnositcs. Fixes #62570Make ItemContext available for better diagnositcs. Fixes #62570Oct 30, 2019
@estebank

estebank commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 31, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d7869ec has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2019
@estebankestebank changed the title Make ItemContext available for better diagnositcs. Fixes #62570Make ItemContext available for better diagnositcsOct 31, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Nov 1, 2019
@tmandry
Rollup merge ofrust-lang#65902- gilescope:issue62570, r=estebank
d75338e
Make ItemContext available for better diagnositcs
Fixrust-lang#62570
@tmandrytmandry mentioned this pull request Nov 1, 2019
Merged
bors added a commit that referenced this pull request Nov 1, 2019
@bors
Auto merge of#66021- tmandry:rollup-y13l6n9, r=tmandry
87cbf0a
Rollup of 16 pull requests
Successful merges:
- #65112 (Add lint and tests for unnecessary parens around types)
- #65470 (Don't hide ICEs from previous incremental compiles)
- #65471 (Add long error explanation for E0578)
- #65857 (rustdoc: Resolve module-level doc references more locally)
- #65902 (Make ItemContext available for better diagnositcs)
- #65914 (Use structured suggestion for unnecessary bounds in type aliases)
- #65946 (Make `promote_consts` emit the errors when required promotion fails)
- #65960 (doc: reword iter module example and mention other methods)
- #65963 (update submodules to rust-lang)
- #65972 (Fix libunwind build: Define __LITTLE_ENDIAN__ for LE targets)
- #65977 (Fix incorrect diagnostics for expected type in E0271 with an associated type)
- #65995 (Add error code E0743 for "C-variadic has been used on a non-foreign function")
- #65997 (Fix outdated rustdoc of Once::init_locking function)
- #66002 (Stabilize float_to_from_bytes feature)
- #66005 (vxWorks: remove code related unix socket)
- #66018 (Revert PR 64324: dylibs export generics again (for now))
Failed merges:
r? @ghost
@bors
bors merged commit d7869ec into rust-lang:masterNov 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank left review comments

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async blocks are leaky about wording wrt. ? in diagnostics

6 participants

@gilescope@rust-highfive@Centril@estebank@bors@cramertj