Uh oh!
There was an error while loading. Please reload this page.
submodules: update clippy from 66df92ae to c8e3cfbd - #65904
Merged
Conversation
Changes: ```` travis: temporarily disable rustfmt ci check until rust-lang#4742 is resolved rustup rust-lang#65792 Fix ICE rust-lang#4579 Add regression test for ICE rust-lang#4579 Run update_lints for Unicode lint Re-add false positive check Add raw string regression test for useless_format lint Re-factor useless_format lint Update Unicode lint tests [Backported] Rustup to rust-lang#59545 ```` Fixes #rust-lang#65888
rust-highfive
commented
Oct 28, 2019
Contributor
|
Manishearth
commented
Oct 28, 2019
Member
@bors r+ |
bors
commented
Oct 28, 2019
Collaborator
📌 Commit f9ac609 has been approved by |
Contributor
Did you use the clippy on master branch? The clippy commits in this PR seems really old. |
Manishearth
commented
Oct 29, 2019
via email
Member
It was a merge-in of backport commits, they're supposed to be old …On Mon, Oct 28, 2019, 8:04 PM lzutao ***@***.***> wrote:
Did you use the clippy on master branch? The clippy commits in this PR
seems really old.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65904?email_source=notifications&email_token=AAMK6SFYHBOUMTU5X77TE63QQ6R37A5CNFSM4JF7H3SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECPCLXY#issuecomment-547235295>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK6SG2ZMXDFGZG5SWUX5TQQ6R37ANCNFSM4JF7H3SA>
.
|
matthiaskrgr
commented
Oct 29, 2019
MemberAuthor
Could we get a prio bump? Otherwise this might not land before clippy is broken again. |
Manishearth
commented
Oct 29, 2019
via email
Member
@bors p=1 …On Tue, Oct 29, 2019, 4:23 AM Matthias Krüger ***@***.***> wrote:
Could we get a prio bump? Otherwise this might not land before clippy is
broken again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65904?email_source=notifications&email_token=AAMK6SBPIU6NB3RT5PYJZUDQRAMM3A5CNFSM4JF7H3SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQEIJQ#issuecomment-547374118>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK6SDGM5PSOKTKSTLTSS3QRAMM3ANCNFSM4JF7H3SA>
.
|
bors
commented
Oct 29, 2019
Collaborator
bors added a commit
that referenced
this pull request
Oct 29, 2019
submodules: update clippy from 66df92a to c8e3cfb Changes: ```` travis: temporarily disable rustfmt ci check until #4742 is resolved rustup #65792 Fix ICE #4579 Add regression test for ICE #4579 Run update_lints for Unicode lint Re-add false positive check Add raw string regression test for useless_format lint Re-factor useless_format lint Update Unicode lint tests [Backported] Rustup to #59545 ```` Fixes#65888 r? @oli-obk@Manishearth
bors
commented
Oct 29, 2019
Collaborator
☀️ Test successful - checks-azure |
rust-highfive
commented
Oct 29, 2019
Contributor
📣 Toolstate changed by #65904! Tested on commit caa1f8d. 🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 29, 2019
Tested on commit rust-lang/rust@caa1f8d. Direct link to PR: <rust-lang/rust#65904> 🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra). 💔 rls on windows: test-fail → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes#65888
r? @oli-obk@Manishearth