Uh oh!
There was an error while loading. Please reload this page.
syntax: move stuff around - #65916
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
davidtwco
requested changes
Oct 29, 2019
davidtwco
left a comment
Member
There was a problem hiding this comment.
I'd like to see the last commit's changes squashed into the relevant commits that introduced the issues, but otherwise, r=me.
Centril
commented
Oct 30, 2019
ContributorAuthor
Squashed -- was easier than I feared. :) @bors r=davidtwco |
bors
commented
Oct 30, 2019
Collaborator
📌 Commit 27adef62d6e8f73e5645eb8ad7f5bbcb9d595122 has been approved by |
Centril
commented
Oct 30, 2019
ContributorAuthor
I'm not even going to try getting this through CI now that the toolstate week is in effect. :) @bors r- |
This comment has been minimized.
This comment has been minimized.
Centrilforce-pushed
the
split-syntax-3
branch
2 times, most recently
from
November 6, 2019 06:09
2d04b43 to
948674bCompareCentril
commented
Nov 6, 2019
ContributorAuthor
Toolstate should be breakable again, @bors r=davidtwco |
bors
commented
Nov 6, 2019
Collaborator
📌 Commit 948674b6e94af25d7c64dbd91ba235467140457a has been approved by |
This comment has been minimized.
This comment has been minimized.
Centril
commented
Nov 6, 2019
ContributorAuthor
@bors r=davidtwco |
bors
commented
Nov 6, 2019
Collaborator
📌 Commit 7514dcdb8e8cf50a0ca6415d1b513e424b7c3144 has been approved by |
This comment has been minimized.
This comment has been minimized.
Centril
commented
Nov 7, 2019
ContributorAuthor
@bors r=davidtwco |
bors
commented
Nov 7, 2019
Collaborator
📌 Commit cc9c139 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Nov 7, 2019
syntax: move stuff around Part of rust-lang#65324. r? @davidtwco cc @estebank@petrochenkov
bors added a commit
that referenced
this pull request
Nov 7, 2019
Rollup of 5 pull requests Successful merges: - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore) - #64696 ([rustdoc] add sub settings) - #65916 (syntax: move stuff around) - #66087 (Update some build-pass ui tests to use check-pass where applicable) - #66182 (invalid_value lint: fix help text) Failed merges: r? @ghost
Merged
bors added a commit
that referenced
this pull request
Nov 7, 2019
Rollup of 5 pull requests Successful merges: - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore) - #64696 ([rustdoc] add sub settings) - #65916 (syntax: move stuff around) - #66087 (Update some build-pass ui tests to use check-pass where applicable) - #66182 (invalid_value lint: fix help text) Failed merges: r? @ghost
tesuji added a commit
to tesuji/rust-clippy
that referenced
this pull request
Nov 8, 2019
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 8, 2019
rustup rust-lang/rust#65916 cc rust-lang/rust#65916 changelog: none
tesuji added a commit
to tesuji/rust-clippy
that referenced
this pull request
Nov 8, 2019
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 8, 2019
rustup rust-lang/rust#65916 cc rust-lang/rust#65916 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #65324.
r? @davidtwco
cc @estebank@petrochenkov