Skip to content

Updates to core::tuple - #6595

Closed
brendanzab wants to merge 6 commits into
rust-lang:incomingfrom
brendanzab:core-tuple
Closed

Updates to core::tuple#6595
brendanzab wants to merge 6 commits into
rust-lang:incomingfrom
brendanzab:core-tuple

Conversation

@brendanzab

@brendanzabbrendanzab commented May 18, 2013

Copy link
Copy Markdown
Contributor

No description provided.

@brendanzab

brendanzab commented May 19, 2013

Copy link
Copy Markdown
ContributorAuthor

This is odd (only on linux):

error: pretty-printed source does not typecheck
command: x86_64-unknown-linux-gnu/stage2/bin/rustc - --no-trans --lib -L x86_64-unknown-linux-gnu/test/run-pass -L x86_64-unknown-linux-gnu/test/run-pass/issue-2631-b.libaux -O --target=x86_64-unknown-linux-gnu
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
<anon>:14:0: 14:15 error: multiple matching crates for `req`
<anon>:14 extern mod req;
^~~~~~~~~~~~~~~
note: candidates:
note: path: x86_64-unknown-linux-gnu/test/run-pass/issue-2631-b.libaux/libreq-bef4e145ee4b741-0.0.so
note: meta: name = "req"
note: meta: vers = "0.0"
note: path: x86_64-unknown-linux-gnu/test/run-pass/issue-2631-b.libaux/libreq-94839cbfe144198-0.0.so
note: meta: name = "req"
note: meta: vers = "0.0"
error: aborting due to previous error
------------------------------------------

error: pretty-printed source does not typecheck
command: x86_64-unknown-linux-gnu/stage2/bin/rustc - --no-trans --lib -L x86_64-unknown-linux-gnu/test/run-pass -L x86_64-unknown-linux-gnu/test/run-pass/issue2378c.libaux -O --target=x86_64-unknown-linux-gnu
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
<anon>:16:0: 16:22 error: multiple matching crates for `issue2378b`
<anon>:16 extern mod issue2378b;
^~~~~~~~~~~~~~~~~~~~~~
note: candidates:
note: path: x86_64-unknown-linux-gnu/test/run-pass/issue2378c.libaux/libissue2378b-fdb18dcf4e777077-0.0.so
note: meta: name = "issue2378b"
note: meta: vers = "0.0"
note: path: x86_64-unknown-linux-gnu/test/run-pass/issue2378c.libaux/libissue2378b-4cb1dac9b641e5a-0.0.so
note: meta: name = "issue2378b"
note: meta: vers = "0.0"
error: aborting due to previous error
------------------------------------------

error: pretty-printed source does not typecheck
command: x86_64-unknown-linux-gnu/stage2/bin/rustc - --no-trans --lib -L x86_64-unknown-linux-gnu/test/run-pass -L x86_64-unknown-linux-gnu/test/run-pass/pub-use-xcrate.libaux -O --target=x86_64-unknown-linux-gnu
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
<anon>:15:0: 15:27 error: multiple matching crates for `pub_use_xcrate2`
<anon>:15 extern mod pub_use_xcrate2;
^~~~~~~~~~~~~~~~~~~~~~~~~~~
note: candidates:
note: path: x86_64-unknown-linux-gnu/test/run-pass/pub-use-xcrate.libaux/libpub_use_xcrate2-fdb18dcf4e777077-0.0.so
note: meta: name = "pub_use_xcrate2"
note: meta: vers = "0.0"
note: path: x86_64-unknown-linux-gnu/test/run-pass/pub-use-xcrate.libaux/libpub_use_xcrate2-4cb1dac9b641e5a-0.0.so
note: meta: name = "pub_use_xcrate2"
note: meta: vers = "0.0"
error: aborting due to previous error
------------------------------------------
rust: task failed at 'explicit failure', /home/rustbuild/src/rust-buildbot/slave/auto-linux/build/src/compiletest/runtest.rs:724

@brendanzab

brendanzab commented May 19, 2013

Copy link
Copy Markdown
ContributorAuthor

Actually, it happened on osx too.

:(

bors added a commit that referenced this pull request May 19, 2013
@bors
auto merge of#6595: bjz/rust/core-tuple, r=thestinger
3acf378
@borsbors closed this May 19, 2013
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
@bors@Veykril
Mergerust-lang#6595
48bb4bf
6595: Don't wrap parens around expr in remove_dbg assist if its in conditions r=Veykril a=Veykril
If the expr in the `dbg!` macro consists of multiple elements it won't remove the parentheses if its in a `match` or condition-using construct, as these are followed by siblings causing the `is_leaf` check to fail.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendanzab@thestinger@bors@huonw